CTA button component invokes :active with keyboard #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi-unni
requested review from
rmccar,
precious-onyenaucheya-ons and
alessioventuriniAND
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adi-unni
changed the title
rmccar
approved these changes
Nov 2, 2023
precious-onyenaucheya-ons
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Changed styles and added javascript to the button so that link button which is a a ref styled as a button now has the same behaviours as the "button" buttons. When pressing the link-button in the CTA and otherwise, it now depresses and comes back.
How to review this PR
Navigate to Call to Action button and click on the button with mouse and by using by using keyboard space or enter. Visual functionality should be the same between using a mouse and using a keyboard.
Checklist