Change widths of components inside card to be their contents width #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adi-unni
requested review from
rmccar,
precious-onyenaucheya-ons and
alessioventuriniAND
rmccar
requested changes
Oct 5, 2023
rmccar
reviewed
Oct 11, 2023
rmccar
approved these changes
Oct 11, 2023
alessioventuriniAND
approved these changes
Oct 12, 2023
adi-unni
deleted the
fix/2818/focus-states-are-too-wide-on-card-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #2818
Issue was within the card component. Previously, card's components would scale to the width of the whole card, but now scale to just their contents. Additionally, incorrect margin's were being applied to headings within the card, so removing that bring design back in line with other components when tabbing.
How to review this PR
Pressing tab on the card components should reveal new boundaries for focussed states within the card.
Before and After for components changed when focussed:
Checklist
This needs to be completed by the person raising the PR.