-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove form config from base page template #2826
Merged
rmccar
merged 7 commits into
main
from
enhancement/2634/remove-form-config-from-base-page-template
Oct 16, 2023
Merged
Remove form config from base page template #2826
rmccar
merged 7 commits into
main
from
enhancement/2634/remove-form-config-from-base-page-template
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccar
added
Enhancement
Change of existing feature
Breaking changes
This PR contains at least one breaking change
labels
Sep 28, 2023
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
requested review from
alessioventuriniAND,
adi-unni and
precious-onyenaucheya-ons
September 28, 2023 15:08
alessioventuriniAND
approved these changes
Oct 12, 2023
precious-onyenaucheya-ons
approved these changes
Oct 16, 2023
rmccar
deleted the
enhancement/2634/remove-form-config-from-base-page-template
branch
October 16, 2023 09:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This removes the form config from the page template as this is seen as specific code added originally for eQ and therefore should be moved into eQ. I have also moved the preFooter block slightly so that it mirrors the preHeader block and is now inside the page content div.
BREAKING CHANGES
bodyStart
andbodyEnd
blocks to wrap the page contentbodyEnd
block on the page template to outside of thebody
blockHow to review this PR
Checklist
This needs to be completed by the person raising the PR.