Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove form config from base page template #2826

Merged

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Sep 28, 2023

What is the context of this PR?

This removes the form config from the page template as this is seen as specific code added originally for eQ and therefore should be moved into eQ. I have also moved the preFooter block slightly so that it mirrors the preHeader block and is now inside the page content div.

BREAKING CHANGES

  • This PR removes the form element from the page template. If a form is needed on the page this will now need to be set in the service itself using the bodyStart and bodyEnd blocks to wrap the page content
  • This PR moves the bodyEnd block on the page template to outside of the body block

How to review this PR

  • Tests pass
  • DS can be spun up locally and checking a few patterns you can see that the pages are still displayed as expected

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Project for this PR (Design System) and selected the correct status
  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar added Enhancement Change of existing feature Breaking changes This PR contains at least one breaking change labels Sep 28, 2023
@rmccar rmccar self-assigned this Sep 28, 2023
@rmccar rmccar linked an issue Sep 28, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit fda475f
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/652cf7b05930900008f6a7b1
😎 Deploy Preview https://deploy-preview-2826--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar marked this pull request as ready for review September 28, 2023 15:05
@rmccar rmccar removed the Enhancement Change of existing feature label Sep 28, 2023
@rmccar rmccar marked this pull request as draft October 9, 2023 10:31
@rmccar rmccar marked this pull request as ready for review October 12, 2023 10:35
@rmccar rmccar merged commit 0f23239 into main Oct 16, 2023
9 checks passed
@rmccar rmccar deleted the enhancement/2634/remove-form-config-from-base-page-template branch October 16, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes This PR contains at least one breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove form config from base page template
3 participants