Increase underline to match other focussed elements #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adi-unni
requested review from
rmccar,
precious-onyenaucheya-ons and
alessioventuriniAND
rmccar
reviewed
Sep 28, 2023
rmccar
approved these changes
Sep 28, 2023
Remove extra spacing Co-authored-by: rmccar <[email protected]>
adi-unni
force-pushed
the
enhancement/1668/skip-link-hover-state-underline-should-be-thicker
branch
from
68bebf5 to
fe56e7b
Compare
precious-onyenaucheya-ons
approved these changes
Oct 5, 2023
adi-unni
deleted the
enhancement/1668/skip-link-hover-state-underline-should-be-thicker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #1668
Skip link previously had a thin underline when focussed. As the components primary use case is for keyboard users, the route of navigation is through the tab index. When hitting tab, the element gets set from a non visible state, straight to focussed which is the last before an action. As with the rest of the components, the underline should be the thickest when focussed. The change increases the underline thickness to match with the rest of the components' focussed states.
How to review this PR
Press tab to bring up the component and check if the new skip-to-content component has a thicker underline.
Checklist
This needs to be completed by the person raising the PR.