Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #2808

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Sep 21, 2023

What is the context of this PR?

This PR removes the minimist and js-beautify dependencies because they are no longer used.

Part of the fix for this ONSdigital/design-team#9

How to review this PR

  • Tests pass
  • Able to spin up the DS and see it working as expected

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Project for this PR (Design System) and selected the correct status
  • I have selected the correct Assignee
  • I have linked the correct Issue

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 3af674f
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/6512b0119030ff0008e70a6f
😎 Deploy Preview https://deploy-preview-2808--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar added the Dependencies Pull requests that update a dependency file label Sep 21, 2023
@rmccar rmccar self-assigned this Sep 22, 2023
@rmccar rmccar marked this pull request as ready for review September 25, 2023 11:06
@rmccar rmccar merged commit 6533a1e into main Sep 26, 2023
8 checks passed
@rmccar rmccar deleted the dependencies/9/remove-unused-dependencies branch September 26, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants