Change background after colour of checkbox #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi-unni
requested review from
rmccar,
precious-onyenaucheya-ons and
alessioventuriniAND
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
precious-onyenaucheya-ons
approved these changes
Sep 19, 2023
Update prepend file to v2 (#2803) Test signing commit Test 2
adi-unni
force-pushed
the
fix/1800/borderless-checkboxes-should-have-white-background
branch
from
c060f88 to
e11d15f
Compare
…heckboxes-should-have-white-background
alessioventuriniAND
changed the title
adi-unni
deleted the
fix/1800/borderless-checkboxes-should-have-white-background
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes Issue: #1800
Change affects the setting of the background colour for checkboxes when 'focussed' and 'checked' to stop reverting to original colour of background when error has been displayed. Original colour of background when in error, sets initial background to red instead of expected white for the inside of checkbox. Update removes any changes to background colour.
How to review
For all components thats use borderless checkboxes, e.g. example checkboxes without border/ example checkboxes with revealed radios, pass in an error class, and then test by clicking on checkboxes.
Check if background: whilst focussed remains white, whilst checked remains white, whilst unchecked remains white.