Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove list custom attributes deprecation #3337

Closed
rmccar opened this issue Sep 10, 2024 · 0 comments · Fixed by #3336
Closed

Remove list custom attributes deprecation #3337

rmccar opened this issue Sep 10, 2024 · 0 comments · Fixed by #3336
Assignees
Labels
Breaking changes This PR contains at least one breaking change

Comments

@rmccar
Copy link
Contributor

rmccar commented Sep 10, 2024

In #3333 to avoid breaking changes some temporary code needed to put in to continue allowing custom attributes to be set on links within list items. We need to make the changes so that list item custom attributes are now always set on the list item element rather than the link if there is a link in the list item and on the list item if there is no link. This means the functionality is more consistent. On lists where there is only one item the attribute is set on the paragraph element along with any list attributes.

@rmccar rmccar added the Breaking changes This PR contains at least one breaking change label Sep 10, 2024
@rmccar rmccar self-assigned this Sep 10, 2024
@rmccar rmccar closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes This PR contains at least one breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant