merge main

.eslintrc.json

@@ -23,6 +23,7 @@
     "no-var": [1],
     "one-var": [0],
     "max-len": [0, { "code": 140, "ignoreUrls": true }],
-    "comma-dangle": ["error", "always-multiline"]
+    "comma-dangle": ["error", "always-multiline"],
+    "arrow-parens": 1
   }
 }

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,5 +1,19 @@
+<!-- ignore-task-list-start -->
+
 ### What is the context of this PR?
+
 Describe what you have changed and why, link to other PRs or Issues as appropriate.
 
-### How to review
+### How to review this PR
+
 Describe the steps required to test the changes (include screenshots if appropriate).
+
+### Checklist
+
+This needs to be completed by the person raising the PR.
+
+<!-- ignore-task-list-end -->
+
+- [ ] I have selected the correct Project for this PR (Design System) and selected the correct status
+- [ ] I have selected the correct Assignee
+- [ ] I have linked the correct Issue

.github/release.yml

@@ -7,6 +7,9 @@ changelog:
       labels:
         - Component
         - Pattern
+    - title: Accessibility improvements
+      labels:
+        - Accessibility
     - title: Enhancements
       labels:
         - Enhancement
@@ -16,6 +19,9 @@ changelog:
     - title: Documentation
       labels:
         - Documentation
+    - title: Dependency updates
+      labels:
+        - Dependencies
     - title: Other changes
       labels:
         - "*"

.github/workflows/check-checklist.yml

@@ -0,0 +1,17 @@
+name: Checklist Checker
+on:
+  pull_request:
+    types:
+      - opened
+      - edited
+      - synchronize
+      - reopened
+
+jobs:
+  check-tasks:
+    name: Check tasks
+    runs-on: ubuntu-latest
+    steps:
+      - uses: mheap/require-checklist-action@v2
+        with:
+          requireChecklist: false

.github/workflows/check-labels.yml

@@ -0,0 +1,22 @@
+name: Label Checker
+on:
+  pull_request:
+    types:
+      - opened
+      - synchronize
+      - reopened
+      - labeled
+      - unlabeled
+
+jobs:
+  check-labels:
+    name: Check labels
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: read
+    steps:
+      - uses: docker://onsdigital/github-pr-label-checker:v1.2.7
+        with:
+          one_of: Breaking changes,Accessibility,Bug,Documentation,Dependencies,Enhancement,Example
+          none_of: Awaiting resource,Do not merge,Duplicate,Needs validating,Not doing
+          repo_token: ${{ secrets.GITHUB_TOKEN }}

gulpfile.js

@@ -87,7 +87,7 @@ gulp.task('copy-js-files', () => {
   return gulp.src('./src/js/*.js').pipe(gulp.dest('./build/js'));
 });
 
-gulp.task('generate-pages', async function() {
+gulp.task('generate-pages', async function () {
   await generateStaticPages();
 });
 

package.json

@@ -112,7 +112,7 @@
     "pinst": "^3.0.0",
     "postcss": "^8.3.5",
     "postcss-url": "^10.1.3",
-    "prepend-file": "^1.3.1",
+    "prepend-file": "^2.0.1",
     "prettier": "^3.0.0",
     "puppeteer": "^21.0.2",
     "remark-cli": "^11.0.0",

src/components/checkboxes/_checkbox.scss

@@ -94,8 +94,6 @@ $checkbox-padding: 11px;
 
       &:checked,
       &:focus {
-        background-color: initial;
-
         & + .ons-checkbox__label::before {
           background: none;
           border: none;
@@ -123,8 +121,6 @@ $checkbox-padding: 11px;
 
       &:checked,
       &:focus {
-        background-color: initial;
-
         & + .ons-checkbox__label::before {
           background: none;
           border: none;

src/tests/helpers/debug.js

@@ -15,8 +15,8 @@ async function extractTextFromMessage(message) {
     // the actual error text. This is some sort of serialization thing between Chromium and
     // Puppeteer: https://github.com/puppeteer/puppeteer/issues/3397#issuecomment-434970058
     messageParts = await Promise.all(
-      message.args().map(arg =>
-        arg.executionContext().evaluate(arg => {
+      message.args().map((arg) =>
+        arg.executionContext().evaluate((arg) => {
           if (arg instanceof Error) {
             return arg.message;
           } else {
@@ -44,7 +44,7 @@ export function verifyConsoleSubscription(page) {
 
   consoleSubscriptionPage = page;
 
-  page.on('console', async message => {
+  page.on('console', async (message) => {
     const text = await extractTextFromMessage(message);
     quietLog(`browser ${message.type()}: ${text}`, message.type());
 

src/tests/helpers/puppeteer.js

@@ -5,7 +5,7 @@ import { quietLog } from './debug';
 const INTERCEPT_INSTANCE_HEADER_NAME = 'x-test-intercept-instance';
 
 export async function getNodeAttributes(page, selector) {
-  return await page.$eval(selector, node => {
+  return await page.$eval(selector, (node) => {
     const reducer = (map, attr) => {
       map[attr.name] = attr.value;
       return map;
@@ -41,7 +41,7 @@ export class PuppeteerEndpointFaker {
   }
 
   get requestedPaths() {
-    return this.requestHistory.map(entry => entry.path);
+    return this.requestHistory.map((entry) => entry.path);
   }
 
   async setup(page) {
@@ -67,20 +67,20 @@ export class PuppeteerEndpointFaker {
   }
 
   setOverrides(paths, response) {
-    paths.forEach(path => this.setOverride(path, response));
+    paths.forEach((path) => this.setOverride(path, response));
   }
 
   setTemporaryOverride(path, response) {
     this.#temporaryOverrides.set(sanitizeHref(this.baseUrl + path), response);
   }
 
   setTemporaryOverrides(paths, response) {
-    paths.forEach(path => this.setTemporaryOverride(path, response));
+    paths.forEach((path) => this.setTemporaryOverride(path, response));
   }
 
   getRequestCount(path) {
     path = sanitizeHref(path);
-    return this.requestHistory.filter(entry => entry.path === path).length;
+    return this.requestHistory.filter((entry) => entry.path === path).length;
   }
 
   async #refreshInstanceHeader() {