address PR comments

ONSdigital · Oct 3, 2024 · 9bf74e5 · 9bf74e5
1 parent 0e0a3e5
commit 9bf74e5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/components/card/_macro.spec.js b/src/components/card/_macro.spec.js
@@ -8,7 +8,6 @@ import { renderComponent, templateFaker } from '../../tests/helpers/rendering';
 const EXAMPLE_CARD_WITHOUT_IMAGE = {
     title: {
         text: 'Example card title',
-        id: 'example-title-id',
     },
     body: {
         text: 'Example card text.',
@@ -61,7 +60,6 @@ describe('macro: card', () => {
                     title: {
                         text: 'Example card title',
                         headingLevel: headingLevel,
-                        id: 'example-title-id',
                     },
                     body: {
                         text: 'Example card text.',
@@ -70,7 +68,7 @@ describe('macro: card', () => {
                 }),
             );
 
-            expect($(`${expectedTitleTag}#example-title-id`).text().trim()).toBe('Example card title');
+            expect($(`${expectedTitleTag}.ons-card__title`).text().trim()).toBe('Example card title');
         });
 
         it('has the provided `text` accessible via the `textId` identifier', () => {
@@ -129,7 +127,7 @@ describe('macro: card', () => {
         it('has the provided `title` text', () => {
             const $ = cheerio.load(renderComponent('card', EXAMPLE_CARD_WITH_IMAGE));
 
-            expect($('#example-title-id').text().trim()).toBe('Example card title');
+            expect($('.ons-card__title').text().trim()).toBe('Example card title');
         });
 
         it.each([
@@ -141,7 +139,6 @@ describe('macro: card', () => {
                     title: {
                         text: 'Example card title',
                         headingLevel: headingLevel,
-                        id: 'example-title-id',
                     },
                     body: {
                         text: 'Example card text.',
@@ -155,7 +152,7 @@ describe('macro: card', () => {
                 }),
             );
 
-            expect($(`${expectedTitleTag}#example-title-id`).text().trim()).toBe('Example card title');
+            expect($(`${expectedTitleTag}.ons-card__title`).text().trim()).toBe('Example card title');
         });
 
         it('has the provided `text`', () => {

diff --git a/src/components/timeline/_timeline.scss b/src/components/timeline/_timeline.scss
@@ -8,7 +8,7 @@
         height: 100%;
         left: 0;
         position: absolute;
-        top: 10px;
+        top: 12px;
     }
 }
 
@@ -22,7 +22,7 @@
         height: 4px;
         left: -1.5rem;
         position: absolute;
-        top: 10px;
+        top: 12px;
         width: 12px;
     }