changes as per comments

ONSdigital · Nov 28, 2024 · 86c0cc0 · 86c0cc0
1 parent c5d55dc
commit 86c0cc0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 17 deletions.
diff --git a/src/components/hero/_hero.scss b/src/components/hero/_hero.scss
@@ -43,8 +43,8 @@
         height: 100%;
     }
 
-    &__text {
-        padding-bottom: 1rem;
+    &__text:has(+ .ons-btn) {
+        margin-bottom: 2rem;
     }
 
     &__pre-title {
@@ -89,10 +89,6 @@
             }
         }
 
-        &__text {
-            padding: 0;
-        }
-
         &__circle-1 {
             @include mq(l) {
                 background-color: var(--ons-color-spring-green);

diff --git a/src/components/hero/_macro-options.md b/src/components/hero/_macro-options.md
@@ -1,13 +1,13 @@
-| Name           | Type             | Required | Description                                                                                             |
-| -------------- | ---------------- | -------- | ------------------------------------------------------------------------------------------------------- |
-| variants       | array or string  | false    | An array of values or single value (string) to adjust the component using available variant, “dark”     |
-| wide           | boolean          | false    | Set to “true” when using the `wide` page layout container                                               |
-| title          | string           | true     | Text for the hero title                                                                                 |
-| subtitle       | string           | false    | Text for the hero subtitle                                                                              |
-| text           | string           | false    | Text to follow the hero title and subtitle                                                              |
-| button         | `Object<Button>` | false    | Settings for the hero [call to action button](#button)                                                  |
-| html           | string           | false    | Allows arbitrary HTML for additional content to be added to the component                               |
-| detailsColumns | integer          | false    | Number of grid columns for the hero to span on screens larger than the medium breakpoint, defaults to 8 |
+| Name           | Type             | Required | Description                                                                                                           |
+| -------------- | ---------------- | -------- | --------------------------------------------------------------------------------------------------------------------- |
+| variants       | array or string  | false    | An array of values or single value (string) to adjust the component using available variants, “dark” and "navy-blue". |
+| wide           | boolean          | false    | Set to “true” when using the `wide` page layout container                                                             |
+| title          | string           | true     | Text for the hero title                                                                                               |
+| subtitle       | string           | false    | Text for the hero subtitle                                                                                            |
+| text           | string           | false    | Text to follow the hero title and subtitle                                                                            |
+| button         | `Object<Button>` | false    | Settings for the hero [call to action button](#button)                                                                |
+| html           | string           | false    | Allows arbitrary HTML for additional content to be added to the component                                             |
+| detailsColumns | integer          | false    | Number of grid columns for the hero to span on screens larger than the medium breakpoint, defaults to 8               |
 
 ## Button
 

diff --git a/src/components/tabs/_tabs.scss b/src/components/tabs/_tabs.scss
@@ -46,7 +46,7 @@
     height: 2.5rem;
     margin: 0 0.5rem 0 0;
     overflow: visible;
-    padding: 0.25rem 1rem 0.25rem;
+    padding: 0.25rem 1rem;
     position: relative;
     text-decoration: underline;