Skip to content

Commit

Permalink
Merge branch 'main' into fix/2736-error-container-in-pattern-marked-a…
Browse files Browse the repository at this point in the history
…s-hidden-but-has-a-focusable-element
  • Loading branch information
precious-onyenaucheya-ons authored Sep 18, 2023
2 parents ccac132 + 3e51a09 commit 6dbcdfa
Show file tree
Hide file tree
Showing 6 changed files with 1,118 additions and 1,204 deletions.
3 changes: 2 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"no-var": [1],
"one-var": [0],
"max-len": [0, { "code": 140, "ignoreUrls": true }],
"comma-dangle": ["error", "always-multiline"]
"comma-dangle": ["error", "always-multiline"],
"arrow-parens": 1
}
}
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ gulp.task('copy-js-files', () => {
return gulp.src('./src/js/*.js').pipe(gulp.dest('./build/js'));
});

gulp.task('generate-pages', async function() {
gulp.task('generate-pages', async function () {
await generateStaticPages();
});

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"pinst": "^3.0.0",
"postcss": "^8.3.5",
"postcss-url": "^10.1.3",
"prepend-file": "^1.3.1",
"prepend-file": "^2.0.1",
"prettier": "^3.0.0",
"puppeteer": "^21.0.2",
"remark-cli": "^11.0.0",
Expand Down
6 changes: 3 additions & 3 deletions src/tests/helpers/debug.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ async function extractTextFromMessage(message) {
// the actual error text. This is some sort of serialization thing between Chromium and
// Puppeteer: https://github.com/puppeteer/puppeteer/issues/3397#issuecomment-434970058
messageParts = await Promise.all(
message.args().map(arg =>
arg.executionContext().evaluate(arg => {
message.args().map((arg) =>
arg.executionContext().evaluate((arg) => {
if (arg instanceof Error) {
return arg.message;
} else {
Expand Down Expand Up @@ -44,7 +44,7 @@ export function verifyConsoleSubscription(page) {

consoleSubscriptionPage = page;

page.on('console', async message => {
page.on('console', async (message) => {
const text = await extractTextFromMessage(message);
quietLog(`browser ${message.type()}: ${text}`, message.type());

Expand Down
10 changes: 5 additions & 5 deletions src/tests/helpers/puppeteer.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { quietLog } from './debug';
const INTERCEPT_INSTANCE_HEADER_NAME = 'x-test-intercept-instance';

export async function getNodeAttributes(page, selector) {
return await page.$eval(selector, node => {
return await page.$eval(selector, (node) => {
const reducer = (map, attr) => {
map[attr.name] = attr.value;
return map;
Expand Down Expand Up @@ -41,7 +41,7 @@ export class PuppeteerEndpointFaker {
}

get requestedPaths() {
return this.requestHistory.map(entry => entry.path);
return this.requestHistory.map((entry) => entry.path);
}

async setup(page) {
Expand All @@ -67,20 +67,20 @@ export class PuppeteerEndpointFaker {
}

setOverrides(paths, response) {
paths.forEach(path => this.setOverride(path, response));
paths.forEach((path) => this.setOverride(path, response));
}

setTemporaryOverride(path, response) {
this.#temporaryOverrides.set(sanitizeHref(this.baseUrl + path), response);
}

setTemporaryOverrides(paths, response) {
paths.forEach(path => this.setTemporaryOverride(path, response));
paths.forEach((path) => this.setTemporaryOverride(path, response));
}

getRequestCount(path) {
path = sanitizeHref(path);
return this.requestHistory.filter(entry => entry.path === path).length;
return this.requestHistory.filter((entry) => entry.path === path).length;
}

async #refreshInstanceHeader() {
Expand Down
Loading

0 comments on commit 6dbcdfa

Please sign in to comment.