update css and test

ONSdigital · Dec 16, 2024 · 65d5a14 · 65d5a14
1 parent ba37ef9
commit 65d5a14
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 6 deletions.
diff --git a/...ence/ds-vr-test__components_hero_example-hero-analysis_0_document_0_desktop.png b/...ence/ds-vr-test__components_hero_example-hero-analysis_0_document_0_desktop.png
diff --git a/...rence/ds-vr-test__components_hero_example-hero-analysis_0_document_1_tablet.png b/...rence/ds-vr-test__components_hero_example-hero-analysis_0_document_1_tablet.png
diff --git a/...rence/ds-vr-test__components_hero_example-hero-analysis_0_document_2_mobile.png b/...rence/ds-vr-test__components_hero_example-hero-analysis_0_document_2_mobile.png
diff --git a/src/components/hero/_hero.scss b/src/components/hero/_hero.scss
@@ -51,10 +51,6 @@
         height: 100%;
     }
 
-    &__text:has(+ .ons-btn) {
-        margin-bottom: 2rem;
-    }
-
     &__pre-title {
         margin-bottom: 0.5rem;
 

diff --git a/src/components/hero/_macro.njk b/src/components/hero/_macro.njk
@@ -58,7 +58,7 @@
                     {% endif %}
                     {{
                         onsButton({
-                            "classes": btnClasses,
+                            "classes": ' ons-u-mt-s ' + btnClasses,
                             "type": 'button',
                             "text": params.button.text,
                             "url": params.button.url

diff --git a/src/components/hero/_macro.spec.js b/src/components/hero/_macro.spec.js
@@ -78,7 +78,7 @@ describe('macro: hero', () => {
 
         faker.renderComponent('hero', { ...EXAMPLE_HERO, variants: 'dark' });
 
-        expect(buttonSpy.occurrences[0]).toHaveProperty('classes', ' ons-btn--ghost');
+        expect(buttonSpy.occurrences[0]).toHaveProperty('classes', 'ons-u-mt-s ons-btn--ghost');
     });
 
     it('calls with content', () => {