Skip to content

Commit

Permalink
remove has-values class no longer used
Browse files Browse the repository at this point in the history
  • Loading branch information
rmccar committed Oct 28, 2024
1 parent c4ae1a7 commit 5c4d79d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
4 changes: 1 addition & 3 deletions src/components/summary/_macro.njk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@
{% set itemClass = "" %}
{% if row.error %}{% set itemClass = " ons-summary__item--error" %}{% endif %}
{% if row.total %}{% set itemClass = itemClass + " ons-summary__item--total" %}{% endif %}
<div
{% if row.id %}id="{{ row.id }}"{% endif %}class="ons-summary__item{{ itemClass }}{{ ' ons-summary__row--has-values' if item.valueList else "" }}"
>
<div {% if row.id %}id="{{ row.id }}"{% endif %}class="ons-summary__item{{ itemClass }}">
{% if row.errorMessage %}
<div class="ons-summary__row-title--error ons-u-fs-r">{{ row.errorMessage }}</div>
{% endif %}
Expand Down
6 changes: 0 additions & 6 deletions src/components/summary/_macro.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -399,12 +399,6 @@ describe('macro: summary', () => {
expect($('#row-id-3').length).toBe(1);
});

it('has the correct class for each row when there is a `valueList`', () => {
const $ = cheerio.load(renderComponent('summary', EXAMPLE_SUMMARY_BASIC));

expect($('.ons-summary__row--has-values').length).toBe(5);
});

it('has custom row `titleAttributes`', () => {
const $ = cheerio.load(renderComponent('summary', EXAMPLE_SUMMARY_BASIC));

Expand Down

0 comments on commit 5c4d79d

Please sign in to comment.