fix failing test

ONSdigital · Dec 19, 2024 · 32b2240 · 32b2240
1 parent 12506cb
commit 32b2240
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 7 deletions.
diff --git a/...eference/ds-vr-test__components_hero_example-hero-grey_0_document_0_desktop.png b/...eference/ds-vr-test__components_hero_example-hero-grey_0_document_0_desktop.png
diff --git a/...reference/ds-vr-test__components_hero_example-hero-grey_0_document_1_tablet.png b/...reference/ds-vr-test__components_hero_example-hero-grey_0_document_1_tablet.png
diff --git a/...reference/ds-vr-test__components_hero_example-hero-grey_0_document_2_mobile.png b/...reference/ds-vr-test__components_hero_example-hero-grey_0_document_2_mobile.png
diff --git a/src/components/hero/_hero.scss b/src/components/hero/_hero.scss
@@ -329,7 +329,6 @@
             display: grid;
             align-items: start;
             justify-content: space-between;
-            gap: 1rem;
 
             &.ons-hero__title-badge {
                 grid-template-columns: 1fr auto;

diff --git a/src/components/hero/_macro.njk b/src/components/hero/_macro.njk
@@ -25,10 +25,9 @@
                             "classes": 'ons-u-pt-no ' ~ params.breadcrumbs.classes
                         })
                     }}
-
-                    {% if params.topic %}
-                        <h2 class="ons-hero--topic">{{ params.topic | safe }}</h2>
-                    {% endif %}
+                {% endif %}
+                {% if params.topic %}
+                    <h2 class="ons-hero--topic">{{ params.topic | safe }}</h2>
                 {% endif %}
                 <div class="ons-hero__title-container {% if params.badge %}ons-hero__title-badge{% endif %}">
                     <header>

diff --git a/src/components/hero/_macro.spec.js b/src/components/hero/_macro.spec.js
@@ -103,8 +103,8 @@ describe('macro: hero', () => {
     it('outputs the official statistics badge when badge is set to true', () => {
         const $ = cheerio.load(renderComponent('hero', { ...EXAMPLE_HERO, badge: true }));
 
-        expect($('svg').hasClass('ons-hero__badge')).toBe(true);
-        expect($('title').text().trim()).toBe('ons-official-statistics-badge');
+        expect($('.ons-hero__badge').length).toBe(1);
+        expect($('.ons-hero__badge svg title').text().trim()).toBe('Offical Statistics Badge');
     });
 
     it('renders curved gradient when variant is `grey`', () => {