update as per PR comments

ONSdigital · Oct 7, 2024 · 1ba0203 · 1ba0203
1 parent 8e973ca
commit 1ba0203
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 24 deletions.
diff --git a/...vr-test__components_address-input_example-address-input_0_document_2_mobile.png b/...vr-test__components_address-input_example-address-input_0_document_2_mobile.png
diff --git a/...__patterns_addresses_example-address-input-non-editable_0_document_1_tablet.png b/...__patterns_addresses_example-address-input-non-editable_0_document_1_tablet.png
diff --git a/...__patterns_addresses_example-address-input-non-editable_0_document_2_mobile.png b/...__patterns_addresses_example-address-input-non-editable_0_document_2_mobile.png
diff --git a/migration_guides/70.x.x-to-71.0.0-migration-guide.md b/migration_guides/70.x.x-to-71.0.0-migration-guide.md
@@ -61,19 +61,17 @@ This section will list the changes that will impact more than one component
 
         </details>
 
-### **_Update to Icon Sizes Naming Standard_**
+### **_Standardisation of icon size naming_**
 
 [**Link to PR**](https://github.com/ONSdigital/design-system/pull/3285)
 
--   **Description of change:** Icon sizes have been updated with the new naming standard. This change replaces the old naming convention (e.g., xxxl, xxl) with a numerical system (e.g., 3xl, 2xl), similar to the one used for spacing and other components.
+-   **Description of change:** Icon sizes have been updated with to new size naming standard. This change replaces the old naming convention (e.g., xxxl, xxl) with a numerical system (e.g., 3xl, 2xl), similar to the one used for padding and margins.
 
--   **Reason for change:** This update standardizes how sizes are referenced across the system
-
-    This will be a breaking change and will require the renaming of some parameters:
+-   **Reason for change:** This update standardises how sizes are referenced across the system.
 
 -   **Components impacted:**
 
-    Any component or layout where you have manually set the icon size parameter.
+    Anywhere an icon size parameter is set to xxxl or xxl.
 
 -   **Migration steps:**
 
@@ -109,17 +107,17 @@ This section will list the changes that will impact more than one component
 
         </details>
 
-### **_Update to Font Sizes Naming Standard_**
+### **_Standardisation of font size naming_**
 
 [**Link to PR**](https://github.com/ONSdigital/design-system/pull/3285)
 
--   **Description of change:** Font size classes have been updated to reflect the new naming conventions in the Design System. This update replaces the old naming convention (e.g., xxxl, xxl) with a numerical system (e.g., 3xl, 2xl), similar to the one used for spacing and other components.
+-   **Description of change:** Font size classes have been updated to reflect the new size naming convention in the Design System. This update replaces the old naming convention (e.g., xxxl, xxl) with a numerical system (e.g., 3xl, 2xl), similar to the one used for padding and margins.
 
--   **Reason for change:** This update standardizes how sizes are referenced across the system
+-   **Reason for change:** This update standardises how sizes are referenced across the system
 
 -   **Components impacted:**
 
-    Any component or layout where you have manually set the font-size utility classes.
+    Anywhere you use the xxl or xxxl font-size utility classes.
 
 -   **Migration steps:**
 
@@ -161,21 +159,21 @@ This section will list the changes that will impact more than one component
 
         </details>
 
-### **_Update to Grid Breakpoint Naming Standard_**
+### **_Standardisation of breakpoint size naming_**
 
 [**Link to PR**](https://github.com/ONSdigital/design-system/pull/3285)
 
--   **Description of change:** The grid breakpoint naming convention has been updated to a more consistent numerical system. The old breakpoint names like xxs and xxl have been replaced with 2xs, 2xl, and so on, to better align with the numeric sizing system.
+-   **Description of change:** The breakpoint naming convention has been updated to match other size naming like the padding and margin sizes. The old breakpoint size names like xxs and xxl have been replaced with 2xs, 2xl, and so on, to better align with other size naming.
 
 -   **Reason for change:** The new naming convention standardizes how breakpoints are referenced across the design system.
 
 -   **Components impacted:**
 
-    Any component or layout that references grid breakpoints using the previous naming conventions will need to be updated
+    Any component or layout that references breakpoints using the previous naming convention will need to be updated.
 
 -   **Migration steps:**
 
-    1. Locate all instances of grid breakpoints in your codebase.
+    1. Locate all instances of breakpoints in your codebase.
     2. Replace old breakpoint names with the new corresponding names:
 
     -   <details>

diff --git a/src/components/autosuggest/_autosuggest.scss b/src/components/autosuggest/_autosuggest.scss
@@ -96,12 +96,12 @@
         border: 0;
         margin: 0 !important;
         .ons-panel__icon {
-            font-size: 1.3125rem;
-            line-height: 1.5625rem;
+            font-size: 1.3rem;
+            line-height: 1.5rem;
             margin-top: 0;
             min-height: 1.5rem;
-            min-width: 1.625rem;
-            top: 1.0625rem;
+            min-width: 1.5rem;
+            top: 1rem;
         }
 
         .ons-panel__body {