Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

671 post imputation function #5

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

Jday7879
Copy link
Collaborator

@Jday7879 Jday7879 commented Dec 9, 2024

Pull Request Title

671 Post imputation function

Summary

added functions to apply post imputation deriving and constrains after grouping by period and reference
Calculates the sum and will scale imputed values down to ensure total matches pre and post imputation

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Checklists

This pull request meets the following requirements:

Creator Checklist

  • Installable with all dependencies recorded
  • Runs without error
  • Follows PEP8 and project-specific conventions
  • Appropriate use of comments, for example, no descriptive comments
  • Functions documented using Numpy style docstrings
  • Assumptions and decisions log considered and updated if appropriate
  • Unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • Other forms of testing such as end-to-end and user-interface testing have been considered and updated as required

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

Reviewer Checklist

  • Test suite passes (locally as a minimum)
  • Peer reviewed with review recorded

Additional Information

Please provide any additional information or context that would help the reviewer understand the changes in this pull request.

Related Issues

Link any related issues or pull requests here.
Also contains code for 700-write code to import imputation from MBS

- deriving all needed questions as validation check
- Function will print statements if returned and derived values are different
- will rescale imputed values if derived total is higher than returned total
- does nothing if returned and derived are equal
@Jday7879 Jday7879 force-pushed the 671-post-imputation-function branch 2 times, most recently from e296caf to e960dc7 Compare December 10, 2024 10:25
@Jday7879 Jday7879 force-pushed the 671-post-imputation-function branch from e960dc7 to c0e82a1 Compare December 10, 2024 10:32
@Jday7879 Jday7879 marked this pull request as ready for review December 10, 2024 11:06
@Jday7879 Jday7879 requested a review from AntonZogk December 11, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant