Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

668 setup repo structure #2

Merged
merged 7 commits into from
Nov 28, 2024
Merged

668 setup repo structure #2

merged 7 commits into from
Nov 28, 2024

Conversation

Jday7879
Copy link
Collaborator

@Jday7879 Jday7879 commented Nov 26, 2024

Updated the repo structure based on gov cookiecutter

Installs the MBS package from github repo as a requirement, this might need updating to a better method instead of specifying version tags. Works for now

@Jday7879 Jday7879 force-pushed the 668-setup-repo-structure branch from 38eee2d to ea0c91c Compare November 26, 2024 15:47
- Change PR Template
- Create workflows
- Point requirements to MBS repo
- create placeholder unit test for workflows
@Jday7879 Jday7879 force-pushed the 668-setup-repo-structure branch from 5dee255 to 64ab04f Compare November 26, 2024 16:25
@Jday7879 Jday7879 marked this pull request as ready for review November 27, 2024 11:46
@Jday7879 Jday7879 requested a review from AntonZogk November 28, 2024 10:22
setup.cfg Outdated
[metadata]
name = construction_survey_results
description = Project for construction survey
version = 0.0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.0.0 since it's under dev?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change now :)

pyyaml
pandas
numpy
monthly-business-survey-results @ git+https://github.com/ONSdigital/[email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just monthly-business-survey-results will install the latest version available of mbs version deployed in artifactory ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would work internally, but workflows cant connect and get packages from there so unit tests would fail on PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you are right forgot about this, there must be a command to install the latest release from GitHub or we want to pin it ?

Copy link
Collaborator Author

@Jday7879 Jday7879 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spent some time this afternoon trying to point it towards the latest release but couldnt get anywhere. I'll open an issue about this and just merge for now. It will need to be manually updated as we go on but works for now

Copy link
Collaborator

@AntonZogk AntonZogk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good

updating to be same structure as mbs
@Jday7879 Jday7879 merged commit 9fa813d into main Nov 28, 2024
5 checks passed
@Jday7879 Jday7879 deleted the 668-setup-repo-structure branch November 28, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants