-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
668 setup repo structure #2
Conversation
38eee2d
to
ea0c91c
Compare
- Change PR Template - Create workflows - Point requirements to MBS repo - create placeholder unit test for workflows
5dee255
to
64ab04f
Compare
setup.cfg
Outdated
[metadata] | ||
name = construction_survey_results | ||
description = Project for construction survey | ||
version = 0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.0.0 since it's under dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change now :)
pyyaml | ||
pandas | ||
numpy | ||
monthly-business-survey-results @ git+https://github.com/ONSdigital/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just monthly-business-survey-results will install the latest version available of mbs version deployed in artifactory ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would work internally, but workflows cant connect and get packages from there so unit tests would fail on PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you are right forgot about this, there must be a command to install the latest release from GitHub or we want to pin it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spent some time this afternoon trying to point it towards the latest release but couldnt get anywhere. I'll open an issue about this and just merge for now. It will need to be manually updated as we go on but works for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good
updating to be same structure as mbs
Updated the repo structure based on gov cookiecutter
Installs the MBS package from github repo as a requirement, this might need updating to a better method instead of specifying version tags. Works for now