Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote from preprod to prod #388

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Promote from preprod to prod #388

merged 2 commits into from
Nov 5, 2024

Conversation

social-surveys-blaise-concourse
Copy link
Collaborator

Auto generated by concourse:

Promote from preprod to prod

Update 05/11/24:

Took inspiration from the DQS logging functionality

Added server logging using GCP logging library:
Creating a new user
Changing a user's password
Changing a user's role
Deleting a user

Refactored code and improved unit tests:
Changed nodejs backend folder structure for better readability
Included log assertions in test cases
Added new unit tests to cover different scenarios

Out of scope improvements:
Use latest improved blaise-login library
Ensure text inputs are sanitized and trimmed (remove trailling whitespaces) before submitting data
Added unit tests to cover 'bad' text inputs or text inputs with whitespaces 

---------

Co-authored-by: kristian4res <[email protected]>
Promote from main to preprod
@kristian4res kristian4res merged commit 5f6ef5c into prod Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants