Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote from BLAIS5-4254 to main #386

Merged
merged 42 commits into from
Nov 5, 2024
Merged

Promote from BLAIS5-4254 to main #386

merged 42 commits into from
Nov 5, 2024

Conversation

social-surveys-blaise-concourse
Copy link
Collaborator

Auto generated by concourse:

Promote from BLAIS5-4254 to main

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 30 lines in your changes missing coverage. Please review.

Project coverage is 62.12%. Comparing base (8e94f82) to head (41721d5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/logger/cloudLogging.ts 46.66% 16 Missing ⚠️
server/routes/blaiseApi.ts 88.23% 10 Missing ⚠️
server/server.ts 76.92% 3 Missing ⚠️
src/pages/users/UserUpload/NewUser.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   60.63%   62.12%   +1.48%     
==========================================
  Files          36       37       +1     
  Lines         818      866      +48     
  Branches      185      194       +9     
==========================================
+ Hits          496      538      +42     
- Misses        322      328       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

server/AuditLogger/index.ts Fixed Show fixed Hide fixed
server/AuditLogger/index.ts Fixed Show fixed Hide fixed
server/BlaiseAPI/index.ts Fixed Show fixed Hide fixed
server/index.ts Fixed Show fixed Hide fixed
server/logger/cloudLogging.ts Fixed Show fixed Hide fixed
server/logger/cloudLogging.ts Fixed Show fixed Hide fixed
server/server.ts Fixed Show fixed Hide fixed
server/server.ts Fixed Show fixed Hide fixed
server/tests/index.test.ts Fixed Show fixed Hide fixed
server/tests/index.test.ts Fixed Show fixed Hide fixed
server/routes/blaiseApi.ts Fixed Show fixed Hide fixed
src/pages/users/UserProfileEdits/ChangePassword.test.tsx Dismissed Show dismissed Hide dismissed
server/logger/cloudLogging.ts Fixed Show fixed Hide fixed
server/logger/cloudLogging.ts Dismissed Show dismissed Hide dismissed
server/routes/blaiseApi.ts Fixed Show fixed Hide fixed
server/logger/cloudLogging.ts Dismissed Show dismissed Hide dismissed
@kristian4res kristian4res marked this pull request as ready for review November 5, 2024 15:04
Copy link
Contributor

@kristian4res kristian4res left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer reviewed by Ben
Discussed and demo'd to other devs (including tech lead)
👍 🦖 👍

@kristian4res kristian4res merged commit 8e1a250 into main Nov 5, 2024
6 checks passed
@kristian4res kristian4res deleted the BLAIS5-4254 branch November 5, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants