Fixes #1817: support key alias #3145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
requested review from
Copilot,
WanjohiSammy,
habbes,
mikepizzo,
ElizabethOkerio and
gathogojr
|
I'd like to move the key alias feature forward. |
There was a problem hiding this comment.
Copilot reviewed 8 out of 23 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- src/Microsoft.OData.Edm/Microsoft.OData.Edm.csproj: Language not supported
- src/Microsoft.OData.Edm/Microsoft.OData.Edm.txt: Language not supported
- src/Microsoft.OData.Edm/PublicAPI/net8.0/PublicAPI.Unshipped.txt: Language not supported
- src/Microsoft.OData.Edm/Csdl/Serialization/EdmModelCsdlSchemaWriter.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Csdl/Parsing/SchemaJsonParser.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Csdl/Semantics/BadElements/UnresolvedPropertyRef.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Csdl/Serialization/EdmModelCsdlSchemaXmlWriter.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Csdl/Serialization/EdmModelCsdlSerializationVisitor.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Microsoft.OData.Edm.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Csdl/Parsing/CsdlDocumentParser.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Validation/EdmErrorCode.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Csdl/Parsing/Ast/CsdlPropertyReference.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Parameterized.Microsoft.OData.Edm.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Schema/Interfaces/IEdmEntityType.cs: Evaluated as low risk
- src/Microsoft.OData.Edm/Schema/EdmEntityType.cs: Evaluated as low risk
Comments skipped due to low confidence (1)
src/Microsoft.OData.Edm/Schema/Interfaces/IEdmPropertyRef.cs:29
- [nitpick] The description for PropertyAlias could be more detailed to explain its purpose and usage.
string PropertyAlias { get; }
| } | ||
|
|
||
| IEdmProperty edmProperty = FindPropertyOnType(edmStructuredType, segment); | ||
| if (i == segment.Length - 1) |
There was a problem hiding this comment.
The condition should be 'if (i == segments.Length - 1)' to correctly identify the last segment in the path.
Suggested change
| if (i == segment.Length - 1) | |
| if (i == segments.Length - 1) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Introduce the IEdmPropertyRef interface Use default interface method for IEdmEntityType avoid breaking changes This change focus on Edm lib, if it's ready and will move to OData.Core.
xuzhg
force-pushed
the
issue1817_SupportKeyAlias
branch
from
943889a to
8540bc5
Compare
| @@ -0,0 +1,30 @@ | |||
| //--------------------------------------------------------------------- | |||
| // <copyright file="UnresolvedProperty.cs" company="Microsoft"> | |||
There was a problem hiding this comment.
This should be UnresolvedPropertyRef.cs instead of UnresolvedProperty.cs
Suggested change
| // <copyright file="UnresolvedProperty.cs" company="Microsoft"> | |
| // <copyright file="UnresolvedPropertyRef.cs" company="Microsoft"> | |
| @@ -650,21 +650,37 @@ internal static CsdlKey ParseCsdlKey(string name, JsonElement keyArray, JsonPars | |||
| Debug.Assert(keyArray.ValueKind == JsonValueKind.Array); | |||
| Debug.Assert(name == "$Key", "The name should be $Key."); | |||
There was a problem hiding this comment.
What if the $Key is in lowercase: $key
| foreach (CsdlPropertyReference keyProperty in this.entity.Key.Properties) | ||
| { | ||
| IEdmStructuralProperty structuralProperty = this.FindProperty(keyProperty.PropertyName) as IEdmStructuralProperty; | ||
| IEdmStructuralProperty structuralProperty = FindKeyProperty(keyProperty.PropertyName); |
There was a problem hiding this comment.
Suggested change
| IEdmStructuralProperty structuralProperty = FindKeyProperty(keyProperty.PropertyName); | |
| IEdmStructuralProperty structuralProperty = this.FindKeyProperty(keyProperty.PropertyName); | |
Or define FindKeyProperty as static method
| @@ -2155,6 +2157,200 @@ public void CanWriteUrlEscapeFunction() | |||
| }"); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void CanWriteEntityType_WithSimpleKey_WithOrWithoutAlias() | |||
There was a problem hiding this comment.
You can add equivalent Async tests for these Sync tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1817: support key alias
Introduce the IEdmPropertyRef interface
Use default interface method for IEdmEntityType avoid breaking changes
This change focus on Edm lib, if it's ready and will move to OData.Core.