Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Documentation System powered by MkDocs and ReadTheDocs #431

Closed
wants to merge 23 commits into from
Closed

New Documentation System powered by MkDocs and ReadTheDocs #431

wants to merge 23 commits into from

Conversation

robertmclaws
Copy link
Collaborator

@robertmclaws robertmclaws commented Jun 8, 2016

Issues

This pull request begins to fix issue #418.

Description

This changes the way documentation is organized and compiled to provide an experience nearly identical to the ASP.NET Documentation site. The future documentation home may reside at http://docs.restier.io as discussed in yesterday's conference call.

Additional work necessary

  • @advancedrei will continue pulling content from the existing documentation in the "gh-pages" branch.
  • @advancedrei will add a new section explaining overall concepts in RESTier for the team to review and improve.
  • @advancedrei will continue documenting examples, and will create new issues for sections that need better real-world examples.
  • Team will need to review written documentation and make sure my additions are accurate based on the capabilities of the code.

PS: I tried to squash this commit down into 1 clean commit, but I clearly didn't do it right. Hopefully you all are better at Git than I am. :)

Thanks!

Robert McLaws added 18 commits June 4, 2016 20:55
Prototyping documentation layout for generating a ReadTheDocs site.
- MethodAuthorization progress
- Changes to the supplemental CSS to better format <code> tags.
- Release notes updates
- More realistic Filters examples
- Temporal Type adjustments
- Contribution Guidelines
- Method authorization tightening
- Interceptors scaffolding
- Interceptors example
- New Method Authorization section on using both techniques at once.
@msftclas
Copy link

msftclas commented Jun 8, 2016

Hi @advancedrei, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@chinadragon0515
Copy link
Contributor

I have seen the PR, we have China Dragon Boat Festival now, I will add comments when I am back to office on Monday.

@robertmclaws
Copy link
Collaborator Author

No worries, have fun at the festival! Looking forward to your thoughts :) I will be working more with RESTier throughout the weekend, so I may push some more documentation updates before then.

mkdocs.yml # The configuration file.
docs/
index.md # The documentation homepage.
... # Other markdown pages, images and other files.
Copy link
Contributor

@chinadragon0515 chinadragon0515 Jun 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a place hold now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is just a placeholder for now, just so the item shows up in the Table of Contents. I will make sure to change it so that it just says something like [THIS IS A PLACEHOLDER FOR FUTURE CONTENT]

- Updates still in progress.
- Also removing placeholder content on other pages.
pages:
- Home:
- 'Introduction': 'index.md'
- 'Getting Started': 'getting-started.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How you think about section header like

  1. Introduction
  2. Getting Started
  3. Building the Services
    3.1 Entity Set Filters

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the numbers out because the ASP.NET team doesn't use them, and the documentation needs to be fairly consistent across the total API surface. Plus, numbers are just one more thing you have to keep up with changing as the docs evolve and new sections are added. I just don't think the benefit is worth the effort.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking number is better to reference like tell people which section, record note with section and so on.

If practice already shows not too much benefit, I am OK now.

@chinadragon0515
Copy link
Contributor

Just for anyone who can merge PR, we need to pass OSS process for mkdocs tool and readthedocs.io site before we can merge this PR per discussion with Mark.

I will initiate this process with help from Mark.

@jmxz
Copy link
Contributor

jmxz commented Jun 20, 2016

OSS for mkdocs has been done. Relevant link

@robertmclaws
Copy link
Collaborator Author

Yay! What's the ETA on readthedocs?

@chinadragon0515
Copy link
Contributor

chinadragon0515 commented Jun 20, 2016

We do not have a ETA yet, we have contacted our domain name management team and share asp .net document information with them, and they will help to contact asp .net team and see what we need to do, then we may get a target date, we will share status here.

In the meanwhile, we can work on the document content and when the process is done, we can push first version of document. @jmxz will help on the document if you need us to own some part.

@robertmclaws
Copy link
Collaborator Author

I don't think this one is going to go anywhere. I'm going to close it for now so I can work on other things. We'll revisit at another time, and I'll link the new PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants