[14.0][FIX] shopfloor: cluster_picking do not create a new move line

[mt-software-de]

When a wrong product is scanned, while setting the qty_done.
The qty done is not changed and no response was returned.
This leads to the error, that a new move line is created.

Now it would be returning that this scanned product is not in the picking
and will not create a new move line.

[OCA-git-bot]

Hi @sebalix, @simahawk, @guewen,
some modules you are maintaining are being modified, check this out!

[mt-software-de]

@TDu could you review this one?

[TDu]

Much better indeed 👍

[mt-software-de]

@jbaudoux could you please review this as well?

[jbaudoux]

It doesn't look correct yet.
If you have 2 lines for the same product but different lots, it's like it is increasing both lines;
Those barcode searches do not look very GS1 friendly. It should call find with the list of handlers (product, packaging, lot)

[mt-software-de]

It doesn't look correct yet.
If you have 2 lines for the same product but different lots, it's like it is increasing both lines;
Those barcode searches do not look very GS1 friendly. It should call find with the list of handlers (product, packaging, lot)

What do you mean? I think my change is correct. The method in generell could be refactored but then also the other places where the different find methods are used.

[jbaudoux]

@mt-software-de can you remind me at which stage in the process this method is called?

[mt-software-de]

@mt-software-de can you remind me at which stage in the process this method is called?

This method is called when you already selected a move line and try to increase the qty done. You can now either scan the package, product or lot to increase it.

[jbaudoux]

Can you also then adapt the lot section below with the same logic?

[mt-software-de]

Can you also then adapt the lot section below with the same logic?

Yes of course this makes sense.

[mt-software-de]

Can you also then adapt the lot section below with the same logic?

done

[jbaudoux]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-950-by-jbaudoux-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 314e7bf. Thanks a lot for contributing to OCA. ❤️