[14.0][ADD] shopfloor_checkout_putinpack_restriction #783
Conversation
TDu
force-pushed
the
14-sf-checkout-putinpack-restriction
branch
3 times, most recently
from
c6e1bdc
to
e423764
Compare
|
This is a replacement for #665 |
| "selected_move_lines": self._data_for_move_lines(lines.sorted()), | ||
| "picking": self.data.picking(picking), | ||
| "packing_info": self._data_for_packing_info(picking), | ||
| "no_package_enabled": not self.options.get("checkout__disable_no_package"), |
There was a problem hiding this comment.
Can we mark this option as deprecated (replaced by shopfloor_checkout_putinpack_restriction) and to drop in future versions?
cc @simahawk
TDu
force-pushed
the
14-sf-checkout-putinpack-restriction
branch
from
f785d48
to
4ec61c5
Compare
|
Rebased, squashed. |
| if picking.put_in_pack_restriction == "no_package": | ||
| res["package_allowed"] = False | ||
| elif picking.put_in_pack_restriction == "with_package": | ||
| res["no_package_enabled"] = False |
There was a problem hiding this comment.
I would make the rule clear here, without relying on the default value of shopfloor.
if picking.put_in_pack_restriction == "no_package":
res["package_allowed"] = False
res["no_package_enabled"] = True
elif picking.put_in_pack_restriction == "with_package":
res["package_allowed"] = True
res["no_package_enabled"] = FalseAnd when we'll remove the no_package_enabled option we won't need to think too much.
|
This PR has the |
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 9208a73. Thanks a lot for contributing to OCA. ❤️ |
Related PR:
OCA/stock-logistics-workflow#1431
Has been merged.