Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] shopfloor_single_product_transfer: check package #758

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[14.0][FIX] shopfloor_single_product_transfer: check package #758

merged 1 commit into from
Nov 21, 2023

Conversation

mt-software-de
Copy link
Contributor

check scanned package

@mt-software-de
Copy link
Contributor Author

cc @jbaudoux @mmequignon

@OCA-git-bot
Copy link
Contributor

Hi @JuMiSanAr, @TDu, @mmequignon,
some modules you are maintaining are being modified, check this out!

@mt-software-de mt-software-de force-pushed the 14.0-fix-shopfloor_single_product_transfer_force_package branch 2 times, most recently from 59777eb to e9e69d5 Compare October 2, 2023 10:30
jbaudoux
jbaudoux approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaudoux
Copy link
Contributor

jbaudoux commented Oct 2, 2023

@mmequignon Can you drop a review?

Ref: rau-235

@mt-software-de mt-software-de changed the title [14.0][FIX] shopfloor_single_product_transfer_force_package [14.0][FIX] shopfloor_single_product_transfer: check package Oct 2, 2023
simahawk
simahawk approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

shopfloor_single_product_transfer/services/single_product_transfer.py Outdated Show resolved Hide resolved
shopfloor_single_product_transfer/services/single_product_transfer.py Outdated Show resolved Hide resolved
shopfloor_single_product_transfer_force_package/services/single_product_transfer.py Outdated Show resolved Hide resolved
shopfloor_single_product_transfer_unique_order_at_location/services/single_product_transfer.py Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mmequignon
mmequignon reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, however instead of changing the signature for both set_quantity and set_destination, I would've created a dedicated handler.
Would be easier to modify the behavior in one enpoint only.

@mt-software-de mt-software-de force-pushed the 14.0-fix-shopfloor_single_product_transfer_force_package branch 2 times, most recently from d5b7572 to 304bf9a Compare November 6, 2023 14:01
@mt-software-de
Copy link
Contributor Author

@simahawk could you merge this one?

@mt-software-de
[FIX] shopfloor_single_product_transfer: Package scan
a6e8dfe 
    Do not remove result_package_id in call of _set_quantity__by_location
    when it was previously set by scanning a package
@mt-software-de mt-software-de force-pushed the 14.0-fix-shopfloor_single_product_transfer_force_package branch from 304bf9a to a6e8dfe Compare November 6, 2023 15:23
@mt-software-de
Copy link
Contributor Author

@simahawk could you merge this one?

or maybe @jbaudoux ?

@jbaudoux
Copy link
Contributor

jbaudoux commented Nov 9, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-758-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 9, 2023
@OCA-git-bot
Merge PR #758 into 14.0
d43d489 
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Contributor

@jbaudoux your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-758-by-jbaudoux-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@mt-software-de
Copy link
Contributor Author

ping @jbaudoux could you retry to merge this?

@jbaudoux
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-758-by-jbaudoux-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8d88898 into OCA:14.0 Nov 21, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3b2c074. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmequignon mmequignon mmequignon left review comments

@jbaudoux jbaudoux jbaudoux approved these changes

@TDu TDu TDu approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mt-software-de @OCA-git-bot @jbaudoux @simahawk @TDu @mmequignon