[14.0][ADD] shopfloor_reception_packaging_dimension #647

TDu · 2023-06-08T08:35:10Z

~~This will still need to be rebased after #559 has been merged.~~

ref.: rau-156

OCA-git-bot · 2023-06-08T08:35:15Z

Hi @simahawk, @JuMiSanAr, @guewen, @sebalix, @mmequignon,
some modules you are maintaining are being modified, check this out!

shopfloor_reception_mobile/static/src/scenario/reception.js

shopfloor_reception_mobile/static/src/scenario/reception_states.js

TDu · 2023-07-07T11:47:52Z

rebased

TDu · 2023-07-11T13:22:52Z

The last 2 commits refactor the modules to allow extending the fields to update on a product.packaging.

shopfloor_reception_packaging_dimension/tests/test_set_package_dimension.py

shopfloor_reception/services/reception.py

TDu · 2023-07-25T13:35:59Z

Squashed and rebased

shopfloor_reception_packaging_dimension/services/reception.py

mt-software-de

Wouldn't it be also good,
to have some button or a logic to create a packaging if none exists?
cc @jbaudoux

jbaudoux · 2023-07-25T14:07:11Z

Wouldn't it be also good, to have some button or a logic to create a packaging if none exists? cc @jbaudoux

Not in this PR

jbaudoux

LG

jbaudoux · 2023-07-25T14:17:37Z

@TDu Can you squash and rebase?

mt-software-de

Some minor remarks

shopfloor_reception_packaging_dimension/services/reception.py

TDu · 2023-07-26T06:18:46Z

Squashed and rebased.

shopfloor/actions/message.py

simahawk · 2023-07-26T06:39:26Z

shopfloor_reception/services/reception.py

@@ -770,6 +770,10 @@ def _align_product_uom_qties(self, move):
            for line in lines:
                line.product_uom_qty = line.qty_done + remaining_todo

+    def _before_response_for_set_quantity(self, picking, line):


the name of this method seems wrong... Is not "before" is actually replacing the direct call to the other method 🤔

It actually inserts a new front end state before the set quantity state if needed. Names can always be improved...

why don't you call it then maybe _response_after_scan_line__assign_user ?

well, it is also called after set_lot_confirm_action so I don't think it it really fits.

TBH I'd prefer something more explicit. The main issue here is that we are trying to change the behavior of something that does not take into account the possibility to handle dimensions.
We could assume - that being a WMS app - we can loosely support such extension.

What if we simply offer an explicit hook here (and everywhere else needed)?
Eg:

if product.tracking not in ("lot", "serial") or (line.lot_id or line.lot_name): if self._requires_packaging_dimension(...): return self._response_for_set_packaging_dimension(...) return self._response_for_set_quantity(picking, line) [....] def _response_for_set_packaging_dimension(self, .....): raise NotImplementedError()

WDYT?

I am not sure why this is better. It adds more coupling between module when not needed.

What is being done here is inserting a new backend state in a scenario before an existing one. When that new state has achieved its purpose (multiple conversation/interaction between the frontend and backend) the scenario will proceed as initially intended.

Now I still agree that the naming is not good. Because the insertion should not be done before generating the response for set_quantity (which is called for the first and subsequent access to the state) but before entering the state set_quantity.

So in that light I refactored the code renaming the function to _before_state__set_quantity.
It does not add coupling and can be used by other modules.

simahawk · 2023-07-26T06:41:22Z

shopfloor_reception_packaging_dimension/hooks.py

+    _logger.info("Add set packaging dimension option on reception scenario")
+    env = api.Environment(cr, SUPERUSER_ID, {})
+    scenario = env.ref("shopfloor_reception.scenario_reception")
+    options = json.loads(scenario.options_edit)


Suggested change

options = json.loads(scenario.options_edit)

options = scenario.options

it's not 🤣

simahawk · 2023-07-26T06:42:53Z

shopfloor_reception_packaging_dimension/services/reception.py

+            self.work.dimension_to_update = {}
+        return self.work.dimension_to_update
+
+    def _before_response_for_set_quantity(self, picking, line):


I don't understand why you needed a new method to override instead of overriding _response_for_set_qty 🤔

It seemed easier at the time. Looking at it now, because _response_for_set_quantity is called in many places in the scenario code and only in a few places we need to inject the packaging dimension check to return a specific response.

_response_for_set_quantity could be called from elsewhere, it's nice to be able to use this hook or not.
I would check if there's packaging available to set dimension where it's relevant, and return _response_for_set_packaging_dimension when we find some.

shopfloor_reception_packaging_dimension/services/reception.py

simahawk · 2023-07-26T06:53:29Z

...or_reception_packaging_dimension_mobile/static/src/scenario/reception_packaging_dimension.js

+// Extend the reception scenario with :
+//   - the new patched template
+//   - the js code for the new state
+const ReceptionPackageDimension = process_registry.extend("reception", {


Can you try this?

Vue.componen("reception", { "methods": { [....] } })

2 reasons for this not to be working.
First one is in how we declare the Vue component for each scenario. At the moment those components are registered as Anonymous Component. But it can be fixed by adding the name key in the scenario component.

The 2nd one is at the time this file is being interpreted by the browser, the Vue component is not created yet, it is created later at the app creation

wms/shopfloor_mobile_base/static/wms/src/main.js

Line 65 in eca1a42

new Vue({

Yeah, you are right. I had an eureka moment some days ago in the shower (and forgot to reply here): the main issue is that scenario components are registered as local components on the root app. That's it.
We should refactor this

wms/shopfloor_mobile_base/static/wms/src/main.js

Line 73 in eca1a42

components: APP_COMPONENTS,

(I mean, drop it, and register such components in the std way).
Go ahead like this for now. Maybe add a TODO then we'll see.

shopfloor_reception_packaging_dimension/services/reception.py

mt-software-de · 2023-07-26T08:37:13Z

shopfloor_reception/services/reception.py

@@ -770,6 +770,10 @@ def _align_product_uom_qties(self, move):
            for line in lines:
                line.product_uom_qty = line.qty_done + remaining_todo

+    def _before_response_for_set_quantity(self, picking, line):


why don't you call it then maybe _response_after_scan_line__assign_user ?

shopfloor_reception_packaging_dimension/services/reception.py

mt-software-de

~~LGTM - except the naming of _before_response_for_set_quantity~~

After testing there must be a change for the js overwrite of the reception states

...or_reception_packaging_dimension_mobile/static/src/scenario/reception_packaging_dimension.js

simahawk · 2023-08-21T15:14:13Z

shopfloor_reception_packaging_dimension/hooks.py

+    _logger.info("Add set packaging dimension option on reception scenario")
+    env = api.Environment(cr, SUPERUSER_ID, {})
+    scenario = env.ref("shopfloor_reception.scenario_reception")
+    options = json.loads(scenario.options_edit)


it's not 🤣

shopfloor_reception_packaging_dimension/hooks.py

simahawk · 2023-08-21T15:36:49Z

shopfloor_reception/services/reception.py

@@ -770,6 +770,10 @@ def _align_product_uom_qties(self, move):
            for line in lines:
                line.product_uom_qty = line.qty_done + remaining_todo

+    def _before_response_for_set_quantity(self, picking, line):


TBH I'd prefer something more explicit. The main issue here is that we are trying to change the behavior of something that does not take into account the possibility to handle dimensions.
We could assume - that being a WMS app - we can loosely support such extension.

What if we simply offer an explicit hook here (and everywhere else needed)?
Eg:

if product.tracking not in ("lot", "serial") or (line.lot_id or line.lot_name): if self._requires_packaging_dimension(...): return self._response_for_set_packaging_dimension(...) return self._response_for_set_quantity(picking, line) [....] def _response_for_set_packaging_dimension(self, .....): raise NotImplementedError()

WDYT?

mt-software-de

Javascript tries to send max_weight but python is looking for weight.

shopfloor_reception_packaging_dimension/services/reception.py

shopfloor_reception_packaging_dimension/tests/test_set_package_dimension.py

TDu · 2023-10-06T14:53:41Z

I have answered or/and fixed all comments.
Rebased as well.

shopfloor_reception_packaging_dimension/models/shopfloor_menu.py

jbaudoux · 2023-10-30T10:03:54Z

@simahawk Are we good now with this one? Can you update your review?
@mt-software-de Your comments have been tackled, can you update your review?

mt-software-de

LGTM

jbaudoux · 2023-10-31T08:11:27Z

@TDu Can you squash ?

simahawk · 2023-11-07T08:50:22Z

/ocabot merge minor

OCA-git-bot · 2023-11-07T08:50:28Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-647-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot · 2023-11-07T09:37:14Z

Congratulations, your PR was merged at 65e4556. Thanks a lot for contributing to OCA. ❤️

simahawk reviewed Jun 8, 2023

View reviewed changes

shopfloor_reception_mobile/static/src/scenario/reception.js Outdated Show resolved Hide resolved

shopfloor_reception_mobile/static/src/scenario/reception_states.js Outdated Show resolved Hide resolved

TDu force-pushed the bsrau-156 branch from 6627868 to 9f28c92 Compare July 7, 2023 11:47

jbaudoux reviewed Jul 24, 2023

View reviewed changes

shopfloor_reception_packaging_dimension/tests/test_set_package_dimension.py Outdated Show resolved Hide resolved

jbaudoux reviewed Jul 24, 2023

View reviewed changes

shopfloor_reception/services/reception.py Outdated Show resolved Hide resolved

TDu force-pushed the bsrau-156 branch 2 times, most recently from e84a932 to 07f86fc Compare July 25, 2023 13:35

mt-software-de suggested changes Jul 25, 2023

View reviewed changes

shopfloor_reception_packaging_dimension/services/reception.py Outdated Show resolved Hide resolved

mt-software-de suggested changes Jul 25, 2023

View reviewed changes

shopfloor_reception_packaging_dimension/services/reception.py Outdated Show resolved Hide resolved

TDu force-pushed the bsrau-156 branch from 07f86fc to b9e9643 Compare July 25, 2023 14:00

mt-software-de reviewed Jul 25, 2023

View reviewed changes

jbaudoux approved these changes Jul 25, 2023

View reviewed changes

mt-software-de suggested changes Jul 25, 2023

View reviewed changes

shopfloor_reception_packaging_dimension/services/reception.py Show resolved Hide resolved

shopfloor_reception_packaging_dimension/services/reception.py Outdated Show resolved Hide resolved

TDu force-pushed the bsrau-156 branch from 40bcfc2 to 84498ff Compare July 26, 2023 06:18

simahawk requested changes Jul 26, 2023

View reviewed changes

mt-software-de suggested changes Jul 26, 2023

View reviewed changes

TDu mentioned this pull request Aug 2, 2023

[14.0] shopfloor_*: fix install/uninstall #700

Merged

mt-software-de approved these changes Aug 2, 2023

View reviewed changes

mt-software-de suggested changes Aug 7, 2023

View reviewed changes

...or_reception_packaging_dimension_mobile/static/src/scenario/reception_packaging_dimension.js Outdated Show resolved Hide resolved

...or_reception_packaging_dimension_mobile/static/src/scenario/reception_packaging_dimension.js Outdated Show resolved Hide resolved

mt-software-de mentioned this pull request Aug 15, 2023

[14.0][ADD] shopfloor_reception_purchase_partner_ref #605

Merged

simahawk reviewed Aug 21, 2023

View reviewed changes

mt-software-de suggested changes Oct 5, 2023

View reviewed changes

shopfloor_reception_packaging_dimension/services/reception.py Outdated Show resolved Hide resolved

shopfloor_reception_packaging_dimension/services/reception.py Outdated Show resolved Hide resolved

mt-software-de suggested changes Oct 5, 2023

View reviewed changes

shopfloor_reception_packaging_dimension/tests/test_set_package_dimension.py Outdated Show resolved Hide resolved

TDu force-pushed the bsrau-156 branch from 034ca5b to db76cba Compare October 6, 2023 14:53

mmequignon reviewed Oct 27, 2023

View reviewed changes

shopfloor_reception_packaging_dimension/models/shopfloor_menu.py Show resolved Hide resolved

mt-software-de approved these changes Oct 30, 2023

View reviewed changes

TDu added 7 commits October 31, 2023 09:17

shopfloor_reception: add hook for reception package dimension

752ea67

shopfloor: add packaging detail action

f9c4219

shopfloor_reception_mobile: imp states inheritance

3d2ee65

Add shopfloor_reception_packaging_dimension

5ab5fa8

Add shopfloor_reception_packaging_dimension_mobile

273c525

sh_reception_packaging_dimension: refactor to allow module to extend

0271954

sh_reception_packaging_dimension_mobile: refactor for extensibility

1d73bae

TDu force-pushed the bsrau-156 branch from db76cba to 1d73bae Compare October 31, 2023 08:46

simahawk approved these changes Nov 7, 2023

View reviewed changes

OCA-git-bot added the approved label Nov 7, 2023

OCA-git-bot added the bot is merging ⏳ label Nov 7, 2023

OCA-git-bot merged commit e78312f into OCA:14.0 Nov 7, 2023
6 of 8 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 7, 2023

	options = json.loads(scenario.options_edit)
	options = scenario.options

[14.0][ADD] shopfloor_reception_packaging_dimension #647

[14.0][ADD] shopfloor_reception_packaging_dimension #647

Conversation

TDu commented Jun 8, 2023 • edited Loading

OCA-git-bot commented Jun 8, 2023

TDu commented Jul 7, 2023

TDu commented Jul 11, 2023

TDu commented Jul 25, 2023

mt-software-de left a comment

Choose a reason for hiding this comment

jbaudoux commented Jul 25, 2023

jbaudoux left a comment

Choose a reason for hiding this comment

jbaudoux commented Jul 25, 2023

mt-software-de left a comment

Choose a reason for hiding this comment

TDu commented Jul 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TDu Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mt-software-de left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mt-software-de left a comment

Choose a reason for hiding this comment

TDu commented Oct 6, 2023

jbaudoux commented Oct 30, 2023

mt-software-de left a comment

Choose a reason for hiding this comment

jbaudoux commented Oct 31, 2023

simahawk commented Nov 7, 2023

OCA-git-bot commented Nov 7, 2023

OCA-git-bot commented Nov 7, 2023

TDu commented Jun 8, 2023 •

edited

Loading

TDu Aug 2, 2023 •

edited

Loading

simahawk Aug 2, 2023 •

edited

Loading

mt-software-de left a comment •

edited

Loading