[16.0][FIX] website_cookiebot: disable for sure #1055
Merged
+19
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Erasing the identifier seems a bit aggressive. Can we convert the boolean into a regular field and change the template to not load it if not checked? |
|
We could do it but that will require more changes and a migration script |
|
Well, I think that the way to go. If not, you lose the ID if you want to disable it temporarily or make some tests. |
chienandalu
force-pushed
the
16.0-fix-disable-cookiebot-for-sure
branch
from
e2eeabb
to
dbe2c86
Compare
|
Ok, done :) |
pedrobaeza
reviewed
Aug 14, 2024
If we don't remove the key the assets will keep trying to load, which isn't what we'd expect. TT50520
chienandalu
force-pushed
the
16.0-fix-disable-cookiebot-for-sure
branch
from
dbe2c86
to
6faa540
Compare
CarlosRoca13
approved these changes
Aug 14, 2024
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at cbd0383. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't remove the key the assets will keep trying to load, which isn't what we'd expect.
cc @Tecnativa TT50520
please review @pedrobaeza @CarlosRoca13