[FIX] membership_extension: No return on super call #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the return we only got the state computed for the first line in self
pedrobaeza
reviewed
Oct 11, 2023
| @@ -43,6 +43,8 @@ def _onchange_membership_date(self): | |||
| self.date_to = date_to | |||
|
|
|||
| def _compute_state(self): | |||
| # Compute methods should not return | |||
| # pylint: disable=missing-return | |||
There was a problem hiding this comment.
Instead of this, just return True at the end.
chienandalu
reviewed
Oct 11, 2023
| @@ -52,7 +54,7 @@ def _compute_state(self): | |||
| ): | |||
| line.state = "canceled" | |||
| else: | |||
| return super(MembershipLine, line)._compute_state() | |||
| super(MembershipLine, line)._compute_state() | |||
There was a problem hiding this comment.
A more performant way would be to avoid splitting the super line by line. Something like:
no_invoice_lines = self.filtered(lambda line: isinstance(line.id, models.NewId) or not line.account_invoice_id)
cancelled_lines = self.filtered(lambda line: line.account_invoice_id.state == "posted" and line.account_invoice_id.payment_state == "reversed")
for line in no_invoice_lines:
line.state = line.state or "none"
cancelled_lines.state = "cancelled"
return super(MembershipLine, (self - no_invoice_lines - cancelled_lines)._compute_state()
|
Superseded by #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the return we only got the state computed for the first line in self