-
-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][IMP] stock_inventory_verification_request: compute involved lines and quant #2187
base: 15.0
Are you sure you want to change the base?
Conversation
Hi @LoisRForgeFlow, |
a28c24c
to
602dd99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
@api.depends("location_id", "product_id", "lot_id", "state") | ||
def _compute_involved_move_lines(self): | ||
for rec in self: | ||
# Solo calcular si el estado es 'open' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments better in English
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I missed this personal comment. Petition attended.
Thank you @AaronHForgeFlow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go one step further, why do you need a comment that states what the code does just right into the next line? I'm not a big friend of comments that explain what code does, an useful comment would be one that explains why something is done. So in this case for me the comment can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment attended
Thank you @LoisRForgeFlow
0273b36
to
7ea8a15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review 👍🏼
This PR has the |
b455d96
to
605ac22
Compare
605ac22
to
a270811
Compare
…tory adjustments button if created_inventory_count is zero
…k.group_production_lot group
If new moves are completed in that location for the specified product after confirming, they should automatically appear in the related lines.
Otherwise, it breaks traceability and hinders easy understanding of the process
Extra commit: do not show related inventory adjustments button if created_inventory_count is zero
2nd Extra commit: show lot_id for stock.group_production_lot group