-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] stock_available_immediately_exclude_location #6
[16.0][ADD] stock_available_immediately_exclude_location #6
Conversation
1ab8cad
to
17e6e34
Compare
stock_available_immediately_exclude_location/models/product_product.py
Outdated
Show resolved
Hide resolved
17e6e34
to
3e30add
Compare
3e30add
to
7f10527
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Code review)
@rousseldenis Could you update your review PLZ? |
# exclude the element from domain and replace by something True | ||
location_domain.append((1, "=", 1)) # True and domain compatible | ||
elif expression.is_leaf(element): | ||
location_domain.append( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glitchov This is weird that tests don't pass in this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glitchov Could you check my comment ?
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@rousseldenis I think this one is good. Can you update your review? |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at f7fec73. Thanks a lot for contributing to OCA. ❤️ |
Exclude location(s) from the computation of immediately usable quantity