Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] stock_available_immediately_exclude_location #6

Conversation

glitchov
Copy link
Contributor

Exclude location(s) from the computation of immediately usable quantity

@glitchov glitchov force-pushed the 16.0-mig-stock_available_immediately_exclude_location-hda branch from 1ab8cad to 17e6e34 Compare January 18, 2023 14:13
@glitchov glitchov force-pushed the 16.0-mig-stock_available_immediately_exclude_location-hda branch from 17e6e34 to 3e30add Compare January 20, 2023 10:14
@glitchov glitchov force-pushed the 16.0-mig-stock_available_immediately_exclude_location-hda branch from 3e30add to 7f10527 Compare January 24, 2023 12:35
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review)

@lmignon
Copy link
Contributor

lmignon commented Jan 25, 2023

@rousseldenis Could you update your review PLZ?

@rousseldenis rousseldenis added this to the 16.0 milestone Jan 25, 2023
# exclude the element from domain and replace by something True
location_domain.append((1, "=", 1)) # True and domain compatible
elif expression.is_leaf(element):
location_domain.append(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glitchov This is weird that tests don't pass in this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glitchov Could you check my comment ?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 28, 2023
@github-actions github-actions bot closed this Jul 2, 2023
@rousseldenis rousseldenis reopened this Jul 3, 2023
@github-actions github-actions bot closed this Aug 6, 2023
@rousseldenis rousseldenis reopened this Oct 9, 2023
@github-actions github-actions bot closed this Nov 12, 2023
@jbaudoux jbaudoux reopened this Nov 23, 2023
@jbaudoux jbaudoux added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Nov 23, 2023
@jbaudoux
Copy link

jbaudoux commented Apr 8, 2024

@rousseldenis I think this one is good. Can you update your review?

@jbaudoux
Copy link

jbaudoux commented Apr 8, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-6-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0c8c80a into OCA:16.0 Apr 8, 2024
8 of 10 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f7fec73. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-mig-stock_available_immediately_exclude_location-hda branch April 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 needs review no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants