Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] dbfilter_from_header: Migration to 18.0 #3099

Merged
merged 20 commits into from
Nov 12, 2024

Conversation

remytms
Copy link
Contributor

@remytms remytms commented Oct 29, 2024

No description provided.

hbrunn and others added 19 commits October 29, 2024 14:08
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
[MIG] migrate dbfilter_from_header to 10.0

I have also removed the ability to use HTTP_X_OPENERP_DBFILTER

Signed-off-by: Carmen Bianca Bakker <[email protected]>
updates were made in OCA#1137 by @TimLai125

and small lint fixes by @yelizariev

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>

[UPD] Update dbfilter_from_header.pot

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[UPD] README.rst

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>

[UPD] Update dbfilter_from_header.pot

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>

[UPD] Update dbfilter_from_header.pot

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[UPD] README.rst

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>

[UPD] Update dbfilter_from_header.pot

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[UPD] README.rst

Signed-off-by: Carmen Bianca Bakker <[email protected]>
@remytms remytms changed the title [MIG] dbfilter_from_header: Migration to 18.0 [18.0][MIG] dbfilter_from_header: Migration to 18.0 Oct 29, 2024
@remytms remytms force-pushed the 18.0-mig-dbfilter_from_header branch from 270c090 to dc46843 Compare October 29, 2024 14:06
@remytms remytms marked this pull request as ready for review October 29, 2024 14:06
Copy link

@mostafabarmshory mostafabarmshory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All things seams ok, but test coverage.

@mostafabarmshory
Copy link

@remytms

Any news?
I could not understand why this was not merged with branch 18.0.
Even not listed in #3047

@remytms
Copy link
Contributor Author

remytms commented Nov 11, 2024

The issue you mentionned is for OpenUpgrade script, that why this OCA module is not listed there. OpenUpgrade scripts are only for standard Odoo module.

Each repository is manager by PSCs, and they can decide if this can be merge with the red ci for test coverage. PSC can be found here.

@houssine78
Copy link

/ocabot migration dbfilter_from_header

@OCA-git-bot
Copy link
Contributor

Sorry @houssine78 you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Copy link

@houssine78 houssine78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houssine78
Copy link

@pedrobaeza this PR can be merged too. thanks !

@pedrobaeza
Copy link
Member

/ocabot migration dbfilter_from_header
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 12, 2024
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3099-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 12, 2024
23 tasks
@OCA-git-bot OCA-git-bot merged commit e7b75a1 into OCA:18.0 Nov 12, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e9c7a1f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.