[17.0][IMP] server_environment: allow to overwrite odoo config options #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-hatakeyama
suggested changes
Nov 13, 2024
| @@ -6,7 +6,7 @@ are stored in the `server_environment_files` companion module. | |||
|
|
|||
| The `server_environment_files` module is optional, the values can be set | |||
| using an environment variable with a fallback on default values in the | |||
| database. | |||
| database. You will be able to overwrite some odoo options. | |||
There was a problem hiding this comment.
Can all options be changed?
If only some options can be changed, it would help to document which ones.
There was a problem hiding this comment.
Yes all odoo options of the config file can be overwritten this way.
There was a problem hiding this comment.
Then I suggest this change:
Suggested change
| database. You will be able to overwrite some odoo options. | |
| database. You will be able to overwrite any Odoo options. |
There was a problem hiding this comment.
IMO this sentence is confusing if we don't give extra details (with the key server_environment_allow_overwrite_options_section,...).
But all this is already explained in the "Configured" section.
I think it's better to keep it as it is with a simple description.
… server_environment_files
qgroulard
force-pushed
the
17.0-forwardport-server_environment_overwrite_odoo_options-qgr
branch
from
133e08e
to
782afd4
Compare
vincent-hatakeyama
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #159