Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] auth_signup_verify_email: Migration to 18.0 #727

Open
wants to merge 31 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] auth_signup_verify_email: Migration to 18.0 #727

wants to merge 31 commits into from
+1,574 −0

Commits on Nov 14, 2024

  1. [9.0][MIG][auth_signup_verify_email] Migration. (OCA#436) 

    * Add module auth_signup_verify_email.

* Import module following guidelines.

* README typos.

* OCA Transbot updated translations from Transifex

* Credit creator.

* author name correction

* [9.0][MIG][auth_signup_verify_email] Migration.

Migrate to v9.

* [FIX] auth_signup_verify_email: Python library requirement

* Add tests, fix xml tags, fix credits.

* Fix test.
    @yajo @jr2-adhoc
    yajo authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e0080c5 View commit details
    Browse the repository at this point in the history

  2. [MIG][10] auth_signup_verify_email 

    * Module set to installable
* Odoo don't let signup without password
    @sharkende @jr2-adhoc
    sharkende authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    201d940 View commit details
    Browse the repository at this point in the history

  3. OCA Transbot updated translations from Transifex

    @oca-transbot @jr2-adhoc
    oca-transbot authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8ec7fe9 View commit details
    Browse the repository at this point in the history

  4. [MIG][11] auth_signup_verify_email

    @simahawk @jr2-adhoc
    simahawk authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a6cfd3b View commit details
    Browse the repository at this point in the history

  5. [FIX+REF] auth_signup_verify_email: Fix tests + Skip mail send in tes… 

    …ts and use email_validator (OCA#29)

This addon introduced an integration conflict when tested in a database that had `mail_tracking_mass_mailing` installed, producing this failure:

    Traceback (most recent call last):
    File "/opt/odoo/auto/addons/auth_signup_verify_email/controllers/main.py", line 44, in passwordless_signup
        sudo_users.reset_password(values.get("login"))
    File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
        self.gen.next()
    File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 419, in savepoint
        self.execute('RELEASE SAVEPOINT "%s"' % name)
    File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 154, in wrapper
        return f(self, *args, **kwargs)
    File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 231, in execute
        res = self._obj.execute(query, params)
    InternalError: no such savepoint

Which in turn produced the following in the next test:

    InternalError: current transaction is aborted, commands ignored until end of transaction block

The problem comes from the fact that one cannot rollback to a nested savepoint if the parent savepoint was released. It became a problem because that's the strategy that both this addon and upstream's `TestCursor` follow.

To avoid that, tests now mock the `send_mail` method. This results also in having a predictable outcome from the test `test_good_email`, so it is more meaningful now.

Besides, previously we were using the `validate_email` package, which is currently a dead project that can silently fail under certain environments, as seen in syrusakbary/validate_email#80.

There's the `email_validator` package, freely available, supported, and it provides a human-readable error message whenever some format from the email fails.

As such, here I'm switching the dependency, while still adding a backwards compatibility layer for preexisting installations.
    @yajo @jr2-adhoc
    yajo authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5f66fbf View commit details
    Browse the repository at this point in the history

  6. [FIX] auth_signup_verify_email: Improve signup error messages 

    * When try to login with a not valid email domain it raised a 500 server
  error. Now we shwt the proper message "The domain name <domain> does not
  exist."
* If there is any error we do not have catched when we do the email
  validation then we manage it and show the error message to the user instead
  of 500 server error.
* When we try to register with a already registered email it raise "Something
  went wrong, please try again later or contact us". Now shows the message
  as odoo regular signup does: "Another user is already registered using this
  email address" which is more specific and clear for this case.
    @zaoral @jr2-adhoc
    zaoral authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d817ebb View commit details
    Browse the repository at this point in the history

  7. [MIG] auth_signup_verify_email: Migration to 12.0

    @Tardo @jr2-adhoc
    Tardo authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b6b9574 View commit details
    Browse the repository at this point in the history

  8. Translated using Weblate (Portuguese (Brazil)) 

    Currently translated at 100.0% (4 of 4 strings)

Translation: server-auth-12.0/server-auth-12.0-auth_signup_verify_email
Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_signup_verify_email/pt_BR/
    @jr2-adhoc
    Rodrigo Macedo authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d01b6fa View commit details
    Browse the repository at this point in the history

  9. Translated using Weblate (Croatian) 

    Currently translated at 100.0% (4 of 4 strings)

Translation: server-auth-12.0/server-auth-12.0-auth_signup_verify_email
Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_signup_verify_email/hr/
    @badbole @jr2-adhoc
    badbole authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ab13401 View commit details
    Browse the repository at this point in the history

  10. [IMP] auth_signup_verify_email: Remove hack

    @Tardo @jr2-adhoc
    Tardo authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    afcdac4 View commit details
    Browse the repository at this point in the history

  11. [FIX] auth_signup_verify_email: make tests compatible with website 

    This commit fixes 2 problems:

1.  `auth_signup.allow_uninvited` ICP is no longer used.
    The new equivalent is `auth_signup.invitation_scope=b2c`.
2.  If running tests in an environment where `website` is installed,
    the website needs to get public signup enabled or tests here would
    fail with an error like this:

        2020-02-19 12:36:31,686 35 INFO prod odoo.modules.module: odoo.addons.auth_signup_verify_email.tests.test_verify_email running tests.
        2020-02-19 12:36:31,686 35 INFO prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: test_bad_email (odoo.addons.auth_signup_verify_email.tests.test_verify_email.UICase)
        2020-02-19 12:36:31,686 35 INFO prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ` Test rejection of bad emails.
        2020-02-19 12:36:31,735 35 INFO ? odoo.http: HTTP Configuring static files
        2020-02-19 12:36:31,738 35 INFO prod odoo.addons.base.models.ir_http: Generating routing map
        2020-02-19 12:36:34,227 35 INFO prod werkzeug: 127.0.0.1 - - [19/Feb/2020 12:36:34] "GET /web/signup HTTP/1.1" 404 - 763 0.262 2.227
        2020-02-19 12:36:34,231 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ERROR
        2020-02-19 12:36:34,231 35 INFO prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: test_good_email (odoo.addons.auth_signup_verify_email.tests.test_verify_email.UICase)
        2020-02-19 12:36:34,231 35 INFO prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ` Test acceptance of good emails.
        2020-02-19 12:36:36,293 35 INFO prod werkzeug: 127.0.0.1 - - [19/Feb/2020 12:36:36] "GET /web/signup HTTP/1.1" 404 - 759 0.258 1.797
        2020-02-19 12:36:36,296 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ERROR
        2020-02-19 12:36:36,297 35 INFO prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ======================================================================
        2020-02-19 12:36:36,297 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ERROR: test_bad_email (odoo.addons.auth_signup_verify_email.tests.test_verify_email.UICase)
        2020-02-19 12:36:36,297 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ` Test rejection of bad emails.
        2020-02-19 12:36:36,297 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: Traceback (most recent call last):
        2020-02-19 12:36:36,297 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: `   File "/opt/odoo/auto/addons/auth_signup_verify_email/tests/test_verify_email.py", line 20, in setUp
        2020-02-19 12:36:36,297 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: `     "csrf_token": self.csrf_token(),
        2020-02-19 12:36:36,297 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: `   File "/opt/odoo/auto/addons/auth_signup_verify_email/tests/test_verify_email.py", line 33, in csrf_token
        2020-02-19 12:36:36,297 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: `     return doc.xpath("//input[@name='csrf_token']")[0].get("value")
        2020-02-19 12:36:36,297 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ` IndexError: list index out of range
        2020-02-19 12:36:36,297 35 INFO prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ======================================================================
        2020-02-19 12:36:36,298 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ERROR: test_good_email (odoo.addons.auth_signup_verify_email.tests.test_verify_email.UICase)
        2020-02-19 12:36:36,298 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ` Test acceptance of good emails.
        2020-02-19 12:36:36,298 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: Traceback (most recent call last):
        2020-02-19 12:36:36,298 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: `   File "/opt/odoo/auto/addons/auth_signup_verify_email/tests/test_verify_email.py", line 20, in setUp
        2020-02-19 12:36:36,298 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: `     "csrf_token": self.csrf_token(),
        2020-02-19 12:36:36,298 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: `   File "/opt/odoo/auto/addons/auth_signup_verify_email/tests/test_verify_email.py", line 33, in csrf_token
        2020-02-19 12:36:36,298 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: `     return doc.xpath("//input[@name='csrf_token']")[0].get("value")
        2020-02-19 12:36:36,298 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: ` IndexError: list index out of range
        2020-02-19 12:36:36,298 35 INFO prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: Ran 2 tests in 4.611s
        2020-02-19 12:36:36,298 35 ERROR prod odoo.addons.auth_signup_verify_email.tests.test_verify_email: FAILED
        2020-02-19 12:36:36,298 35 INFO prod odoo.addons.auth_signup_verify_email.tests.test_verify_email:  (errors=2)
        2020-02-19 12:36:36,298 35 ERROR prod odoo.modules.module: Module auth_signup_verify_email: 0 failures, 2 errors

@Tecnativa TT21005
    @jr2-adhoc
    Jairo Llopis authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c59e4c0 View commit details
    Browse the repository at this point in the history

  12. [IMP] auth_signup_verify_email: black, isort, prettier

    @em230418 @jr2-adhoc
    em230418 authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8c31d3d View commit details
    Browse the repository at this point in the history

  13. [MIG] auth_signup_verify_email: Migration to 13.0

    @em230418 @jr2-adhoc
    em230418 authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c250b7a View commit details
    Browse the repository at this point in the history

  14. Added translation using Weblate (Arabic) 

    Currently translated at 100.0% (4 of 4 strings)

Translation: server-auth-13.0/server-auth-13.0-auth_signup_verify_email
Translate-URL: https://translation.odoo-community.org/projects/server-auth-13-0/server-auth-13-0-auth_signup_verify_email/ar/
    @RachidAlassir @jr2-adhoc
    RachidAlassir authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b4d0b0c View commit details
    Browse the repository at this point in the history

  15. [IMP] auth_signup_verify_email: black, isort, prettier

    @em230418 @jr2-adhoc
    em230418 authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b134fc0 View commit details
    Browse the repository at this point in the history

  16. [MIG] auth_signup_verify_email: Migration to 14.0

    @em230418 @jr2-adhoc
    em230418 authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2741ac9 View commit details
    Browse the repository at this point in the history

  17. [FIX] auth_signup_verify_email: Use real email address for tests 

    In one part of the CI pipeline, the IANA example domains are not
accepted, getting this message from `email_validator` library:

The domain name example.com does not accept email

So we switch to a real domain for avoiding the problem, using our
famous main OCA list address, which at the end, it's not secret and
won't be disabled in a short future.
    @pedrobaeza @jr2-adhoc
    pedrobaeza authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1982d12 View commit details
    Browse the repository at this point in the history

  18. [MIG] auth_signup_verify_email: Migration to 15.0

    @em230418 @jr2-adhoc
    em230418 authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    41cce35 View commit details
    Browse the repository at this point in the history

  19. [IMP] auth_signup_verify_email: pre-commit stuff

    @bruno-zanotti @jr2-adhoc
    bruno-zanotti authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    de9e8dc View commit details
    Browse the repository at this point in the history

  20. [MIG] auth_signup_verify_email: Migration to 16.0

    @bruno-zanotti @jr2-adhoc
    bruno-zanotti authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f59ab47 View commit details
    Browse the repository at this point in the history

  21. Translated using Weblate (Spanish) 

    Currently translated at 100.0% (4 of 4 strings)

Translation: server-auth-16.0/server-auth-16.0-auth_signup_verify_email
Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_signup_verify_email/es/
    @Ivorra78 @jr2-adhoc
    Ivorra78 authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d5504f5 View commit details
    Browse the repository at this point in the history

  22. [IMP] auth_signup_verify_email: pre-commit execution

    @augusto-weiss @jr2-adhoc
    augusto-weiss authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3e4bc4f View commit details
    Browse the repository at this point in the history

  23. [MIG] auth_signup_verify_email: Migration to 17.0

    @augusto-weiss @jr2-adhoc
    augusto-weiss authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0ebf8e5 View commit details
    Browse the repository at this point in the history

  24. [UPD] Update auth_signup_verify_email.pot

    @jr2-adhoc
    oca-ci authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ecf60d4 View commit details
    Browse the repository at this point in the history

  25. [BOT] post-merge updates

    @OCA-git-bot @jr2-adhoc
    OCA-git-bot authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6e96072 View commit details
    Browse the repository at this point in the history

  26. Update translation files 

    Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-auth-17.0/server-auth-17.0-auth_signup_verify_email
Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_signup_verify_email/
    @weblate @jr2-adhoc
    weblate authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2e7d991 View commit details
    Browse the repository at this point in the history

  27. Translated using Weblate (Italian) 

    Currently translated at 100.0% (4 of 4 strings)

Translation: server-auth-17.0/server-auth-17.0-auth_signup_verify_email
Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_signup_verify_email/it/
    @mymage @jr2-adhoc
    mymage authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3073ab3 View commit details
    Browse the repository at this point in the history

  28. Added translation using Weblate (Finnish)

    @jarmokortetjarvi @jr2-adhoc
    jarmokortetjarvi authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d096a78 View commit details
    Browse the repository at this point in the history

  29. Translated using Weblate (Finnish) 

    Currently translated at 100.0% (4 of 4 strings)

Translation: server-auth-17.0/server-auth-17.0-auth_signup_verify_email
Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_signup_verify_email/fi/
    @jarmokortetjarvi @jr2-adhoc
    jarmokortetjarvi authored and jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8edb8ea View commit details
    Browse the repository at this point in the history

  30. [IMP] auth_signup_verify_email: pre-commit execution

    @jr2-adhoc
    jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    bcd39b2 View commit details
    Browse the repository at this point in the history

  31. [MIG] auth_signup_verify_email: Migration to 18.0

    @jr2-adhoc
    jr2-adhoc committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3ed992e View commit details
    Browse the repository at this point in the history