[16.0][MIG] users_ldap_mail: Migration to version 16.0 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadier-Tecnativa
force-pushed
the
16.0-mig-users_ldap_mail
branch
from
838fee4
to
aadd603
Compare
|
ping @sergio-teruel , @pedrobaeza |
|
/ocabot migration users_ldap_mail |
pedrobaeza
reviewed
May 11, 2023
There was a problem hiding this comment.
And please squash a bit administrative commits:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests
Have you checked that the involved methods still exists upstream as there are no tests in the module?
Yadier-Tecnativa
force-pushed
the
16.0-mig-users_ldap_mail
branch
from
aadd603
to
56756c3
Compare
|
Done, please review @carlosdauden , @sergio-teruel |
ADD defsult and sugegsted values; auto-install
Fix PEP8
* [ADD] Add README.rst to users_ldap_mail * [MIG] Migrate users_ldap_mail to 10.0 * [FIX] Fixes in code style in module users_ldap_mail Changes in models/users_ldap_mail include: - remove unused imports - indentation of too long lines * [FIX] users_ldap_mail: Fix copyright notice * [FIX] users_ldap_mail: set UTF-8 encoding users_ldap_mail/models/__init__.py should be UTF-8 encoded * [FIX] users_ldap_mail: remove size argument from Char fields * [FIX] users_ldap_mail: return value can be combined in one line * [FIX] Update read me Fixes included: - Make module name human readable - Instead of numbering steps, use # - Update broken link
…inding byte-code strings
pedrobaeza
force-pushed
the
16.0-mig-users_ldap_mail
branch
from
56756c3
to
e0ab638
Compare
pedrobaeza
approved these changes
Aug 14, 2023
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at bc77e58. Thanks a lot for contributing to OCA. ❤️ |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-auth (17.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT43251