Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][17.0] kpi #936

Open
wants to merge 31 commits into
base: 17.0
Choose a base branch
from
Open

[MIG][17.0] kpi #936

wants to merge 31 commits into from

Conversation

EdgarRetes
Copy link

@max3903 max3903 added this to the 17.0 milestone Oct 10, 2024
@max3903 max3903 self-assigned this Oct 10, 2024
@EdgarRetes EdgarRetes force-pushed the 17.0-mig-kpi branch 8 times, most recently from bb3920b to 2d852c3 Compare November 26, 2024 21:30
naousse and others added 17 commits November 26, 2024 15:33
@naousse @EdgarRetes
mgmtsystem_kpi rename to kpi (OCA#543)
8fd851e 
* kpi migration to odoo 9
* UI error connected
* Correction base on last maxime review
* correction on @elicoidal review
* Warning exception improve in kpi_threshold
* Latest Ellicoidal comment implemented
* last Ellicoial recommendation done.
* Copyright corrected
@ivantodorovich @EdgarRetes
Increase version
8aa41a3
@ivantodorovich @EdgarRetes
Highlight invalid ranges
8be571a
@ivantodorovich @EdgarRetes
Added myself to contributors in README
fbd8f0e
@ivantodorovich @EdgarRetes
Module upgrade is enough
ab5191c
@ivantodorovich @EdgarRetes
Add tests
74a46fe
@AdriaGForgeFlow @EdgarRetes
[MIG] kpi to v11
5f24717
@etobella @EdgarRetes
[IMP] kpi: Add Kanban Views. Improve python code, Allow to access Odoo
d2ced10
@JordiBForgeFlow @EdgarRetes
[kpi] allow to return kpi and color in a single call without thresholds.
d00dcb3
@JordiBForgeFlow @EdgarRetes
add periodicity in minutes
427680f
@JordiBForgeFlow @EdgarRetes
create kpi history as sudo
874d51a
@AdriaGForgeFlow @EdgarRetes
[12.0][MIG] Migrate module kpi to v12
7a8c0fb
@OCA-git-bot @EdgarRetes
[ADD] icon.png
ae19c6b
@EdgarRetes
Translated using Weblate (Portuguese (Brazil))
de0212f 
Currently translated at 100.0% (68 of 68 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/pt_BR/
@oca-transbot @EdgarRetes
Update translation files
c276714 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-12.0/reporting-engine-12.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/
@EdgarRetes
Translated using Weblate (Portuguese (Brazil))
d9867b0 
Currently translated at 100.0% (79 of 79 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/pt_BR/
@EdgarRetes
[IMP] kpi: black, isort
9905a54
flachica and others added 13 commits November 26, 2024 15:33
@EdgarRetes
Migration to 13.0
a2e3544
@oca-travis @EdgarRetes
[UPD] Update kpi.pot
c1f2019
@OCA-git-bot @EdgarRetes
[UPD] README.rst
9d5b21e
@sbidoul @EdgarRetes
Apply dotfiles
54987b4
@OCA-git-bot @EdgarRetes
kpi 13.0.1.0.1
22c2a6e
@mymage @EdgarRetes
Translated using Weblate (Italian)
6894b40 
Currently translated at 29.1% (23 of 79 strings)

Translation: reporting-engine-13.0/reporting-engine-13.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-kpi/it/
@mymage @EdgarRetes
Translated using Weblate (Italian)
aaf5728 
Currently translated at 29.1% (23 of 79 strings)

Translation: reporting-engine-13.0/reporting-engine-13.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-kpi/it/
@mymage @EdgarRetes
Translated using Weblate (Italian)
48cdd76 
Currently translated at 29.1% (23 of 79 strings)

Translation: reporting-engine-13.0/reporting-engine-13.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-kpi/it/
@OCA-git-bot @EdgarRetes
[UPD] README.rst
4f1c165
@weblate @EdgarRetes
Update translation files
66903b5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-13.0/reporting-engine-13.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-kpi/
@mymage @EdgarRetes
Translated using Weblate (Italian)
ebe0d4c 
Currently translated at 28.9% (22 of 76 strings)

Translation: reporting-engine-13.0/reporting-engine-13.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-kpi/it/
@EdgarRetes
[IMP] kpi: pre-commit auto fixes
0e66637
@EdgarRetes
[MIG] kpi: Migration to 17.0
dca7136
@EdgarRetes
Copy link
Author

@max3903

@max3903
Copy link
Member

max3903 commented Nov 26, 2024

@EdgarRetes I get this error message when creating a threshold:

RPC_ERROR
Odoo Server Error

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 1782, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/odoo/http.py", line 1809, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo/http.py", line 2013, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 221, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo/http.py", line 757, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 24, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 20, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 468, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 453, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/addons/web/models/models.py", line 73, in web_save
    self = self.create(vals)
  File "<decorator-gen-162>", line 2, in create
  File "/opt/odoo/odoo/api.py", line 391, in _model_create_single
    return create(self, arg)
  File "/mnt/data/odoo-addons-dir/kpi/models/kpi_threshold.py", line 65, in create
    for range1 in data["range_ids"][0][2]:
IndexError: list index out of range

max3903
max3903 reviewed Nov 26, 2024
View reviewed changes
kpi/static/src/img/icon.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdgarRetes Can you update the icon?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can I find the updated icon?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/OCA/management-system/tree/17.0/mgmtsystem/static/description

@EdgarRetes
Copy link
Author

@EdgarRetes I get this error message when creating a threshold:

RPC_ERROR
Odoo Server Error

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 1782, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/odoo/http.py", line 1809, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo/http.py", line 2013, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 221, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo/http.py", line 757, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 24, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 20, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 468, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 453, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/addons/web/models/models.py", line 73, in web_save
    self = self.create(vals)
  File "<decorator-gen-162>", line 2, in create
  File "/opt/odoo/odoo/api.py", line 391, in _model_create_single
    return create(self, arg)
  File "/mnt/data/odoo-addons-dir/kpi/models/kpi_threshold.py", line 65, in create
    for range1 in data["range_ids"][0][2]:
IndexError: list index out of range

I wasn't able to recreate the error, I didn't have any problems creating a threshold. Can you check again if it works with the last changes?

@max3903
Copy link
Member

max3903 commented Nov 27, 2024

@EdgarRetes It still doesn't work. You can try here:
http://oca-reporting-engine-17-0-pr936-e4015e27de8e.runboat.odoo-community.org/web#action=183&model=kpi.threshold&view_type=list&cids=1&menu_id=124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 left review comments

Assignees

@max3903 max3903

Labels
migration needs fixing needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.