[IMP] report_async: Add eta when async reporting #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kittiu, |
HviorForgeFlow
force-pushed
the
12.0-imp-report_async-add-eta
branch
from
3985e11
to
8ad731d
Compare
report_async/models/report_async.py
Outdated
|
|
||
| def _get_next_schedule_time(self): | ||
| target_time = datetime.strptime(self.schedule_time, "%H:%M").time() | ||
| now = datetime.now() |
There was a problem hiding this comment.
Suggested change
| now = datetime.now() | |
| now = fields.Datetime.now() |
HviorForgeFlow
force-pushed
the
12.0-imp-report_async-add-eta
branch
from
8ad731d
to
e319c1e
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
MiquelRForgeFlow
force-pushed
the
12.0-imp-report_async-add-eta
branch
from
e319c1e
to
cd5fed9
Compare
MiquelRForgeFlow
approved these changes
Jul 19, 2023
|
Hi @kittiu, |
etobella
removed
the
stale
LoisRForgeFlow
approved these changes
Aug 22, 2023
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 3de1f61. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add eta datetime field to decide when to run the queue job.
CC @ForgeFlow