Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] printing_simple_configuration: add company_id to printer #376

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[16.0][FIX] printing_simple_configuration: add company_id to printer #376

merged 1 commit into from
Nov 12, 2024
+39 −3

Conversation

mourad-ehm
Copy link

No description provided.

bealdav
bealdav approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix

@bealdav
Copy link
Member

bealdav commented Nov 12, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Sorry @bealdav you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

pedrobaeza
pedrobaeza previously requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use proper commit message: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@mourad-ehm
[FIX] printing_simple_configuration: add company_id to printer
d5d192f 
[FIX] printing_simple_configuration: add _get_printer_by_usage

[FIX] printing_simple_configuration: dependency

[FIX] printing_simple_configuration: maintainers
@mourad-ehm
Copy link
Author

Thanks @pedrobaeza, I fix it

@pedrobaeza pedrobaeza changed the title FIX add company_id to printer [16.0][FIX] printing_simple_configuration: add company_id to printer Nov 12, 2024
@pedrobaeza pedrobaeza dismissed their stale review November 12, 2024 16:53

Requirements met

@pedrobaeza
Copy link
Member

The change to sale_stock may be heavy, but being a niche module, I'm not opposing to it.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-376-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 17ab2a7 into OCA:16.0 Nov 12, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 65d662c. Thanks a lot for contributing to OCA. ❤️

@bealdav bealdav deleted the 16_add_company_id_to_printer branch November 12, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hparfr hparfr hparfr approved these changes

@bealdav bealdav bealdav approved these changes

@pedrobaeza pedrobaeza pedrobaeza left review comments

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mourad-ehm @bealdav @OCA-git-bot @pedrobaeza @hparfr