Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] attribute_set : Migration 17 #183

Open
wants to merge 50 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] attribute_set : Migration 17 #183

wants to merge 50 commits into from

Conversation

onurugur
Copy link

No description provided.

@onurugur
Copy link
Author

I upgraded the attribute_set module from 16 to 17. What do I need to do to get it checked?
Also worked with runboat. I hope it works.

@onurugur
Copy link
Author

@simahawk I hope you can check it.

@patrickrwilson
Copy link

@onurugur Thank you for migrating, it looks like the commit history wasn't pulled over, can you follow the OCA standards for migration found here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

Also I think there is an issue with this code on the form view
image

It causes the following error when you try to create a 'select' type field and will need to be addressed.
Caused by: EvalError: Can not evaluate python expression: (bool(relation_model_id != False and value_ref in [False, '']))
Error: Name 'relation_model_id' is not defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurugur @patrickrwilson