Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 product search multi value include product variant #180

Conversation

matthieusaison
Copy link

Hi 👋 @sbejaoui @xavier-bouquiaux @Cedric-Pigeon @sbidoul @bealdav

Following of akretion#4 , it's the same PR but on oca/odoo-pim repo.

The related PR was merged (OCA #178), can you merge this one?

Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks a lot @matthieusaison

image

Copy link

@PaulGoubert PaulGoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul
Copy link
Member

sbidoul commented Feb 11, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-180-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 47d20d2 into OCA:16.0 Feb 11, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6df835b. Thanks a lot for contributing to OCA. ❤️

@bealdav bealdav deleted the 16.0-product_search_multi_value-template_and_variant_oca branch February 12, 2024 12:07
@bealdav
Copy link
Member

bealdav commented Feb 12, 2024

Thanks a lot @sbidoul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants