[16.0][IMP] product_attribute_set: allow displaying attributes for product variants #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordiMForgeFlow
commented
Nov 23, 2023
•
JordiMForgeFlow
commented
- Add mixin to product_product model
- Assign attribute set from product template. Allow product_product to have a set related to product_template assigned.
- Add placeholder to easy edit form view (maybe it should be invisible to not overload the easy edit view)
- Allow linking a product variant attribute to a product template set, as the attribute set is managed in the template.
- Show native fields in product variant view.
rousseldenis
approved these changes
Nov 23, 2023
JordiMForgeFlow
force-pushed
the
16.0-imp-product_attribute_set-add_mixin_to_product_product
branch
from
bbd01bc
to
833e44d
Compare
JordiMForgeFlow
force-pushed
the
16.0-imp-product_attribute_set-add_mixin_to_product_product
branch
from
833e44d
to
0567ff8
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
JoanSForgeFlow
approved these changes
May 27, 2024
|
@rousseldenis could we merge this one? :) |
github-actions
bot
removed
the
stale
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 0c26aa7. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.