-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Add new workflow to remove merged branches. #281
base: master
Are you sure you want to change the base?
[IMP] Add new workflow to remove merged branches. #281
Conversation
The idea is that this action is executed in the repository fork to avoid permission problems, but it is included in the main repo to facilitate its propagation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very interesting for keeping the environment cleaned
This looks good to me. |
I'm not sure to understand which branch will be deleted. sorry. Let's take an exemple. If Tecnativa team makes a PR on OCA/web against OCA:16.0, named tecnativa:16.0-IMP-something, Does it mean the branch tecnativa:16.0-IMP-something will be deleted once the PR is merged in OCA:16.0 ? thanks for the precision. |
That is exactly the idea. |
Thanks ! Well, I'm not totally sure of this script. (specially on access right : The event is raised "on" the OCA repo, when a PR is merged, but the script ask to delete a branch of the "tecnativa" organisation.) Could you test it in a custom place, before we deploy this solution in all the OCA repo ? Thanks ! |
@legalsylvain that's not the idea. This should be put on the OCA repos, so that when you fork the branch in your own repository, it acts like explained. Obviously, if someone in OCA does an extra branch, propose a pull request, and gets merged, the branch in OCA will be removed as well. |
looks like there is a setting for that : |
The idea is that this action is executed in the repository fork to avoid permission problems, but it is included in the main repo to facilitate its propagation.
I am not very familiar with how these tools work, so this should be taken more as an idea to be developed than as a PR.
@Tecnativa
ping @josep-tecnativa