Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Add new workflow to remove merged branches. #281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlosdauden
Copy link

@carlosdauden carlosdauden commented Oct 16, 2024

The idea is that this action is executed in the repository fork to avoid permission problems, but it is included in the main repo to facilitate its propagation.

I am not very familiar with how these tools work, so this should be taken more as an idea to be developed than as a PR.

@Tecnativa
ping @josep-tecnativa

The idea is that this action is executed in the repository fork to avoid permission problems, but it is included in the main repo to facilitate its propagation.
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very interesting for keeping the environment cleaned

@josep-tecnativa
Copy link

This looks good to me.

@legalsylvain
Copy link
Contributor

I'm not sure to understand which branch will be deleted. sorry.

Let's take an exemple. If Tecnativa team makes a PR on OCA/web against OCA:16.0, named tecnativa:16.0-IMP-something, Does it mean the branch tecnativa:16.0-IMP-something will be deleted once the PR is merged in OCA:16.0 ?

thanks for the precision.

@carlosdauden
Copy link
Author

Let's take an exemple. If Tecnativa team makes a PR on OCA/web against OCA:16.0, named tecnativa:16.0-IMP-something, Does it mean the branch tecnativa:16.0-IMP-something will be deleted once the PR is merged in OCA:16.0 ?

That is exactly the idea.

@legalsylvain
Copy link
Contributor

That is exactly the idea.

Thanks !

Well, I'm not totally sure of this script. (specially on access right : The event is raised "on" the OCA repo, when a PR is merged, but the script ask to delete a branch of the "tecnativa" organisation.)

Could you test it in a custom place, before we deploy this solution in all the OCA repo ?
(for exemple add the code in tecnativa:16.0 and then create a branch carlosdauden:16.0-TEST and make a PR ? )

Thanks !

@pedrobaeza
Copy link
Member

@legalsylvain that's not the idea. This should be put on the OCA repos, so that when you fork the branch in your own repository, it acts like explained. Obviously, if someone in OCA does an extra branch, propose a pull request, and gets merged, the branch in OCA will be removed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants