Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Move enable_checklog_odoo check outside of nested conditional #275

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[FIX] Move enable_checklog_odoo check outside of nested conditional #275

merged 1 commit into from
Oct 2, 2024

Conversation

PabloEForgeFlow
Copy link
Contributor

No description provided.

@PabloEForgeFlow
Copy link
Contributor Author

@sbidoul as you mentioned on #271, I made enable_checklog_odoo depend on the outer condition.

I fixed that and took the liberty of doing a little refactor to avoid cluttering the outer conditional and improve the clarity of the template, I don't know if it did. Let me know what you think.

@sbidoul
Copy link
Member

sbidoul commented Oct 2, 2024

Sounds good.

The jinja2 docs talks about a do statement that looks cleaner, but I don't know what it takes to enable that. It looks like it's a "extension".

So let's move ahead with this version.

@sbidoul sbidoul merged commit 938784e into OCA:master Oct 2, 2024
7 checks passed
@PabloEForgeFlow
Copy link
Contributor Author

The jinja2 docs talks about a do statement that looks cleaner, but I don't know what it takes to enable that. It looks like it's a "extension".

It appears that copier allows enabling extensions in the copier.yml file. If there's no drawback to enabling it I guess we could do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PabloEForgeFlow @sbidoul