Add version 18 #272
Add version 18 #272
Conversation
src/.github/workflows/{% if ci == 'GitHub' %}test.yml{% endif %}.jinja
Show resolved
Hide resolved
|
The question here is also to bump the linters versions up to the recommended/compatible ones. |
|
The |
I continue to think we should not use poetry nor pin dependencies to test this repo. cc/ @yajo |
SirAionTech
force-pushed
the
add-18.0
branch
from
46a09ed
to
56ee9e1
Compare
SirAionTech
force-pushed
the
add-18.0
branch
2 times, most recently
from
eabb1ed
to
7cf2520
Compare
There you go:
I'd remove that for another alternative but don't know any, so I left it as it was |
|
@sbidoul using Python 3.9 fixes https://github.com/OCA/oca-addons-repo-template/actions/runs/11054931643/job/30712926871#step:8:309
but breaks builds on Ubuntu 20.04 so I have removed them, CI is still requiring them because of some hidden setting I think (that should now include 17 and 18), let me know if I have to do anything |
src/.pre-commit-config.yaml.jinja
Outdated
| @@ -238,7 +238,7 @@ repos: | |||
| additional_dependencies: ["flake8-bugbear=={{ repo_rev.flake8_bugbear }}"] | |||
| {%- else %} | |||
| - repo: https://github.com/astral-sh/ruff-pre-commit | |||
| rev: v0.1.3 | |||
| rev: v0.6.8 | |||
There was a problem hiding this comment.
I think we should have a variable for this ruff version, so we can control which one we use with each Odoo version.
There was a problem hiding this comment.
Is ruff particular? Otherwise I'd fall back to #272 (comment):
I could have left everything < 18 crystallized as it was but maybe they should be updated too from time to time, don't they?
| {%- set repo_rev.prettier = "2.7.1" %} | ||
| {%- set repo_rev.prettier_xml = "2.2.0" %} | ||
| {%- set repo_rev.pylint_odoo = "v8.0.19" %} | ||
| {%- set repo_rev.pylint_odoo = "v9.1.2" %} |
There was a problem hiding this comment.
Is it safe to upgrade all linters for 16 and 17 too? What is the risk of making existing repos red due to new checks?
There was a problem hiding this comment.
Is it safe to upgrade all linters for 16 and 17 too?
Is it safe to keep using the old ones? For how long should we keep using them?
I'm for using the new and shiny things, however I'll change it if you think it's better.
What is the risk of making existing repos red due to new checks?
I'll try the update in a repo to see how much it should change to satisfy the new requirements.
I could have left everything < 18 crystallized as it was but maybe they should be updated too from time to time, don't they?
There was a problem hiding this comment.
I could have left everything < 18 crystallized as it was but maybe they should be updated too from time to time, don't they?
I don't think we should update for previous branches unless necessary. Otherwise tiny changes in linters will make existing branches red, and this is really annoying.
So I would add a new section for 18, with the latest linters.
There was a problem hiding this comment.
Old branches won't be affected unless manually updated. And in that case, pre-commit will update things and maybe ask for new changes, but that can be considered as part of that same manual work. However, it's true that if there must be a mass update of non-pre-commit-related things, that can be problematic. Oftentimes you're the one who does that, @sbidoul, so as you wish.
prettier 3.x with prettier-xml plugin is affected by prettier/prettier#15696
Ubuntu 20.04 uses Python3.8
SirAionTech
force-pushed
the
add-18.0
branch
from
7cf2520
to
b8afd96
Compare
|
Let's try this. Thanks a lot @SirAionTech ! |
No description provided.