Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] mgmtsystem_action: Migration to 18.0 #605

Merged
merged 10 commits into from
Nov 20, 2024
Merged

[18.0][MIG] mgmtsystem_action: Migration to 18.0 #605

merged 10 commits into from
Nov 20, 2024

Conversation

Kimkhoi3010
Copy link
Contributor

No description provided.

m1k3lm and others added 9 commits November 4, 2024 11:34
@m1k3lm @Kimkhoi3010
[17.0] [MIG] mgmtsystem_action
c095ab3
@m1k3lm @Kimkhoi3010
[imp] test coverage
331c18a
@m1k3lm @Kimkhoi3010
[chg] Changes applyied by pre-commit
a9da439
@m1k3lm @Kimkhoi3010
[imp] test coverage
df2285f
@OCA-git-bot @Kimkhoi3010
[BOT] post-merge updates
ad67a93
@weblate @Kimkhoi3010
Update translation files
c9e3d7a 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: management-system-17.0/management-system-17.0-mgmtsystem_action
Translate-URL: https://translation.odoo-community.org/projects/management-system-17-0/management-system-17-0-mgmtsystem_action/
@mymage @Kimkhoi3010
Translated using Weblate (Italian)
28644ac 
Currently translated at 100.0% (119 of 119 strings)

Translation: management-system-17.0/management-system-17.0-mgmtsystem_action
Translate-URL: https://translation.odoo-community.org/projects/management-system-17-0/management-system-17-0-mgmtsystem_action/it/
@weblate @Kimkhoi3010
Update translation files
73a4ca2 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: management-system-17.0/management-system-17.0-mgmtsystem_action
Translate-URL: https://translation.odoo-community.org/projects/management-system-17-0/management-system-17-0-mgmtsystem_action/
@Kimkhoi3010
[IMP] mgmtsystem_action: pre-commit auto fixes
6764153
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@max3903 max3903 added this to the 18.0 milestone Nov 19, 2024
@max3903 max3903 self-assigned this Nov 19, 2024
@max3903
Copy link
Member

max3903 commented Nov 19, 2024

/ocabot migration mgmtsystem_action

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 19, 2024
Open
14 tasks
@max3903
Copy link
Member

max3903 commented Nov 19, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-605-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 19, 2024
@OCA-git-bot
Merge PR #605 into 18.0
2a11f7d 
Signed-off-by max3903
@OCA-git-bot
Copy link
Contributor

@max3903 your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-605-by-max3903-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

TDu
TDu reviewed Nov 20, 2024
View reviewed changes
mgmtsystem_action/views/mgmtsystem_action.xml Outdated
<field name="message_needaction_counter" />
<templates>
<field name="date_deadline" />
<t t-name="kanban-box">
Copy link
Member

@TDu TDu Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kimkhoi3010 This line is preventing this module to be merged, could you fix it please
https://github.com/OCA/management-system/actions/runs/11903685874/job/33171125454#step:8:92
Thank you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for your time!

@natuan9 natuan9 mentioned this pull request Nov 20, 2024
Open
@max3903
Copy link
Member

max3903 commented Nov 20, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-605-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5026581 into OCA:18.0 Nov 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 47ef6a0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDu TDu TDu approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees

@max3903 max3903

Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Kimkhoi3010 @OCA-git-bot @max3903 @TDu @ivantodorovich @m1k3lm @weblate @mymage