Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apps store link if OCA #403

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

elicoidal
Copy link
Contributor

cc @OCA/board

@pedrobaeza
Copy link
Member

For reducing the diff in all READMEs, switch the order of the sentences. You have to check tests also (there are tests for README generation).

@sbidoul
Copy link
Member

sbidoul commented Feb 19, 2019

Changes to the readme generator must be considered very carefully, because the nightly regeneration job will trigger many commits and republish all modules to pypi.

@elicoidal
Copy link
Contributor Author

no clear why travis is failing

@elicoidal
Copy link
Contributor Author

@pedrobaeza I understand the diff problem but I prefer this order which makes more sense to me.
@sbidoul Fully agree and I am open to suggestion: this is a follow up about some discussion with the board about increasing the SEO of the shop.
Maybe we should queue the modifications and wait for another significant one.

@pedrobaeza
Copy link
Member

@elicoidal they are unconnected things, so the order is not so important, so for me, they should go the other way for decreasing the diff.

@elicoidal
Copy link
Contributor Author

@pedrobaeza the logic is "Here is the work we do hence if you want to contribute ..."
The other way around is "Contribute. Here is the work we do"

This is why I propose this order

@pedrobaeza
Copy link
Member

Well, I still think the other way is correct also, so I prefer to not switch it.

@elicoidal
Copy link
Contributor Author

I am not convinced but have no time to fight this

@pedrobaeza
Copy link
Member

Please rebase to get a green Travis

@elicoidal
Copy link
Contributor Author

@pedrobaeza I dont know how to interpret the travis and fix the PR. Can you help me?

@pedrobaeza
Copy link
Member

@elicoidal
Copy link
Contributor Author

You have to change test

@pedrobaeza Sorry I do not know how to do that... Help is welcome to finish this.

@pedrobaeza
Copy link
Member

@sbidoul does this makes sense still?

@sbidoul
Copy link
Member

sbidoul commented Oct 18, 2021

Not sure. Our app store is not in very good shape so I'd hesitate to do this at the moment.

Also, I'm wondering if we should not change the bot to not do README.rst generation in the nightly batch, but only do it in ocabot merge or even pre-commit. Not sure.

@pedrobaeza
Copy link
Member

pedrobaeza commented Oct 18, 2021

What do you mean by "Our app store is not in very good shape"? I use as my first OCA modules info source with no problems.

@sbidoul
Copy link
Member

sbidoul commented Oct 18, 2021

Well I may overreact but I remember several people reporting problems and there used to be some synchronization issues to keep it up-to-date. Maybe these have been fixed by now.

@pedrobaeza
Copy link
Member

I think they were all addressed, but anyways, if any persists, we should fix it (and you can consider that as part of the warranty of the migration), but don't dismiss the "pipelining" to it for avoiding the rest of the issues with Odoo Apps Store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants