-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apps store link if OCA #403
base: master
Are you sure you want to change the base?
Conversation
For reducing the diff in all READMEs, switch the order of the sentences. You have to check tests also (there are tests for README generation). |
Changes to the readme generator must be considered very carefully, because the nightly regeneration job will trigger many commits and republish all modules to pypi. |
no clear why travis is failing |
@pedrobaeza I understand the diff problem but I prefer this order which makes more sense to me. |
@elicoidal they are unconnected things, so the order is not so important, so for me, they should go the other way for decreasing the diff. |
@pedrobaeza the logic is "Here is the work we do hence if you want to contribute ..." This is why I propose this order |
Well, I still think the other way is correct also, so I prefer to not switch it. |
I am not convinced but have no time to fight this |
Please rebase to get a green Travis |
@pedrobaeza I dont know how to interpret the travis and fix the PR. Can you help me? |
You have to change tests in https://github.com/OCA/maintainer-tools/blob/master/tests/test_gen_addon_readme.py |
@pedrobaeza Sorry I do not know how to do that... Help is welcome to finish this. |
@sbidoul does this makes sense still? |
Not sure. Our app store is not in very good shape so I'd hesitate to do this at the moment. Also, I'm wondering if we should not change the bot to not do README.rst generation in the nightly batch, but only do it in ocabot merge or even pre-commit. Not sure. |
What do you mean by "Our app store is not in very good shape"? I use as my first OCA modules info source with no problems. |
Well I may overreact but I remember several people reporting problems and there used to be some synchronization issues to keep it up-to-date. Maybe these have been fixed by now. |
I think they were all addressed, but anyways, if any persists, we should fix it (and you can consider that as part of the warranty of the migration), but don't dismiss the "pipelining" to it for avoiding the rest of the issues with Odoo Apps Store. |
cc @OCA/board