Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] l10n_it_riba: remove account and journal domain #4455

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions l10n_it_ricevute_bancarie/models/riba_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class RibaConfiguration(models.Model):
"account.account",
"A/C Bank Account",
check_company=True,
domain="[('company_id', '=', company_id), ('internal_type', '=', 'liquidity')]",
domain="[('company_id', '=', company_id)]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questo si può togliere: quando il dominio è solo per multicompany, l'attributo check_company inietta già il dominio corretto (vedi https://github.com/odoo/odoo/blob/d7f13b50148d0a3ec764dc37b0ca3631c9a35483/odoo/fields.py#L2541).

)
bank_expense_account_id = fields.Many2one("account.account", "Bank Fees Account")
unsolved_journal_id = fields.Many2one(
Expand All @@ -79,7 +79,7 @@ class RibaConfiguration(models.Model):
"account.account",
"Past Due Bills Account",
check_company=True,
domain="[('company_id', '=', company_id), ('internal_type', '=', 'receivable')]",
domain="[('company_id', '=', company_id)]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anche questo si può togliere, vedi l'altro commento sul codice simile.

)
protest_charge_account_id = fields.Many2one(
"account.account",
Expand Down
2 changes: 0 additions & 2 deletions l10n_it_ricevute_bancarie/wizard/wizard_unsolved.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ def _get_bank_expense_account_id(self):
effects_account_id = fields.Many2one(
"account.account",
"Bills Account",
domain=[("internal_type", "=", "receivable")],
default=_get_effects_account_id,
)
effects_amount = fields.Float("Bills Amount", default=_get_effects_amount)
Expand All @@ -77,7 +76,6 @@ def _get_bank_expense_account_id(self):
overdue_effects_account_id = fields.Many2one(
"account.account",
"Past Due Bills Account",
domain=[("internal_type", "=", "receivable")],
default=_get_overdue_effects_account_id,
)
overdue_effects_amount = fields.Float(
Expand Down
Loading