[14.0][IMP] add ability to set intrastat only for in_ or out_ invoices in l10n_it_intrastat #4256

sergiocorato · 2024-07-09T15:05:06Z

No description provided.

MaurizioPellegrinet

Test funzionale: OK

sergiocorato · 2024-07-10T07:04:37Z

Test funzionale: OK

Grazie, ho fatto delle ulteriori modifiche per un discorso funzionale: ho rimosso il campo Intrastat generico e lasciato solo i due nuovi campi, così che sia chiaro all'utente di cosa sta impostando.
Ho aggiunto uno script di migrazione che va a settare a True i due nuovi campi quando il campo Intrastat è impostato.

MaurizioPellegrinet

Conferma alle modifiche: OK

github-actions · 2024-11-10T12:33:04Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

SirAionTech

Grazie della PR!
Ho fatto revisione del codice e provato la migrazione, che però è da modificare perché la versione 14.0.1.4.3 è stata assegnata nel frattempo; quindi
/ocabot rebase

SirAionTech · 2024-11-11T08:18:39Z

l10n_it_intrastat/models/account.py

+            self.move_type.startswith("out_")
+            and self.fiscal_position_id.intrastat_sale
+            or self.move_type.startswith("in_")


Penso sia meglio usare is_purchase_document e is_sale_document, che ne dici?

SirAionTech · 2024-11-11T08:21:14Z

l10n_it_intrastat/models/account.py

-                    .browse(val["fiscal_position_id"])
-                    .intrastat
+            if "fiscal_position_id" in val:
+                fiscal_position_id = self.env["account.fiscal.position"].browse(


Potrebbe essere utile

Suggested change

fiscal_position_id = self.env["account.fiscal.position"].browse(

fiscal_position = self.env["account.fiscal.position"].browse(

Per distinguere che le variabili con _id sono degli interi, cosa ne pensi?

SirAionTech · 2024-11-11T08:22:44Z

l10n_it_intrastat/models/account.py

+                        if val.get("move_type").startswith("out_"):
+                            intrastat = fiscal_position_id.intrastat_sale
+                        elif val.get("move_type").startswith("in_"):


Analogamente a quanto suggerito sopra, si potrebbero usare get_sale_types e get_purchase_types, che ne dici?

SirAionTech · 2024-11-11T08:25:01Z

l10n_it_intrastat/views/account.xml

-                        <field name="intrastat" />
+                        <field name="intrastat_purchase" />
+                        <field name="intrastat_sale" />


Il campo rimosso era citato nella documentazione, potresti aggiornarla?

SirAionTech · 2024-11-11T08:27:24Z

l10n_it_intrastat/tests/test_intrastat.py

@@ -65,11 +65,12 @@ def test_invoice_totals(self):
        )
        self.assertEqual(total_intrastat_amount, invoice.amount_untaxed)

-    def test_invoice_fiscal_postion(self):
+    def test_invoice_fiscal_position(self):


Questo ora è diventato il test per verificare che funzioni intrastat_sale, penso che andrebbe modificata la firma; faresti il test analogo per verificare intrastat_purchase?

SirAionTech · 2024-11-11T08:47:20Z

l10n_it_intrastat/migrations/14.0.1.4.3/pre-migrate.py

+        ("account_fiscal_position", "intrastat_sale"),
+        ("account_fiscal_position", "intrastat_purchase"),
+    ]:
+        if not openupgrade.column_exists(env.cr, table, column):


column_exists esiste solo per retrocompatibilità, si potrebbe usare invece il metodo omonimo di openupgrade_tools?
Vedi https://github.com/OCA/openupgradelib/blob/8d04b103b70d6927f805b94ef26ecf53b26e51ed/openupgradelib/openupgrade.py#L411

P.S.: esiste anche odoo.tools.sql.column_exists

OCA-git-bot · 2024-11-11T08:50:34Z

@SirAionTech The rebase process failed, because command git push --force efatto tmp-pr-4256:14.0-imp-l10n_it_intrastat-add-option-by-move-type failed with output:

remote: Permission to efatto/l10n-italy.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/efatto/l10n-italy/': The requested URL returned error: 403

OCA-git-bot · 2024-11-11T08:50:37Z

@SirAionTech The rebase process failed, because command git push --force efatto tmp-pr-4256:14.0-imp-l10n_it_intrastat-add-option-by-move-type failed with output:

remote: Permission to efatto/l10n-italy.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/efatto/l10n-italy/': The requested URL returned error: 403

…es in l10n_it_intrastat

sergiocorato mentioned this pull request Jul 9, 2024

l10n_it_intrastat non è possibile distinguere nella posizione fiscale se l'intrastat è obbligatorio solo per le vendite o gli acquisti #4257

Open

2 tasks

sergiocorato linked an issue Jul 9, 2024 that may be closed by this pull request

l10n_it_intrastat non è possibile distinguere nella posizione fiscale se l'intrastat è obbligatorio solo per le vendite o gli acquisti #4257

Open

2 tasks

sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch 2 times, most recently from f3b5e08 to 6380399 Compare July 9, 2024 15:19

MaurizioPellegrinet approved these changes Jul 9, 2024

View reviewed changes

sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch 3 times, most recently from 027bfe1 to fe86928 Compare July 10, 2024 06:58

MaurizioPellegrinet approved these changes Jul 10, 2024

View reviewed changes

sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch from fe86928 to 53b8fd7 Compare July 10, 2024 12:22

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024

SirAionTech requested changes Nov 11, 2024

View reviewed changes

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 17, 2024

sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch 3 times, most recently from b7dd497 to 2a0a5fd Compare November 22, 2024 17:14

sergiocorato requested a review from SirAionTech November 22, 2024 17:16

sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch 2 times, most recently from f5e4add to 1694d65 Compare November 22, 2024 17:19

y[14.0][IMP] add ability to set intrastat only for in_ or out_ invoic…

c5950a2

…es in l10n_it_intrastat

sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch from 1694d65 to c5950a2 Compare November 25, 2024 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][IMP] add ability to set intrastat only for in_ or out_ invoices in l10n_it_intrastat #4256

[14.0][IMP] add ability to set intrastat only for in_ or out_ invoices in l10n_it_intrastat #4256

sergiocorato commented Jul 9, 2024

MaurizioPellegrinet left a comment

sergiocorato commented Jul 10, 2024

MaurizioPellegrinet left a comment

github-actions bot commented Nov 10, 2024

SirAionTech left a comment

SirAionTech Nov 11, 2024

sergiocorato Nov 22, 2024

SirAionTech Nov 11, 2024

sergiocorato Nov 22, 2024

SirAionTech Nov 11, 2024

sergiocorato Nov 22, 2024

SirAionTech Nov 11, 2024

sergiocorato Nov 22, 2024

SirAionTech Nov 11, 2024

sergiocorato Nov 22, 2024

SirAionTech Nov 11, 2024 •

edited

Loading

sergiocorato Nov 22, 2024

OCA-git-bot commented Nov 11, 2024

OCA-git-bot commented Nov 11, 2024

	fiscal_position_id = self.env["account.fiscal.position"].browse(
	fiscal_position = self.env["account.fiscal.position"].browse(

[14.0][IMP] add ability to set intrastat only for in_ or out_ invoices in l10n_it_intrastat #4256

Are you sure you want to change the base?

[14.0][IMP] add ability to set intrastat only for in_ or out_ invoices in l10n_it_intrastat #4256

Conversation

sergiocorato commented Jul 9, 2024

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

sergiocorato commented Jul 10, 2024

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 10, 2024

SirAionTech left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SirAionTech Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 11, 2024

OCA-git-bot commented Nov 11, 2024

SirAionTech Nov 11, 2024 •

edited

Loading