Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][l10n_it_intrastat_statement] Fix credit note compensation not in period #3889

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[14.0][l10n_it_intrastat_statement] Fix credit note compensation not in period #3889

merged 1 commit into from
Jan 26, 2024

Conversation

robyf70
Copy link
Contributor

@robyf70 robyf70 commented Jan 24, 2024

La PR fixa il problema della compensazione delle note di credito emesse/ricevute che fanno riferimento a fatture NON del periodo considerato dalla dichiarazione

@robyf70 robyf70 mentioned this pull request Jan 24, 2024
Open
2 tasks
@francesco-ooops francesco-ooops linked an issue Jan 24, 2024 that may be closed by this pull request
[14/16][l10n_it_intrastat_statement] Bug sulla compensazione delle note di credito emesse/ricevute #3890
Open
2 tasks
@robyf70 robyf70 force-pushed the 14.0-l10n_it_intrastat_statement-fix_compensation_not_in_period branch 5 times, most recently from 522d0d0 to e1882b4 Compare January 25, 2024 10:16
sergiocorato
sergiocorato reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ottima PR grazie.
Riesci a caricare un test apposito? Ci sono già alcuni test simili.

@robyf70
Copy link
Contributor Author

robyf70 commented Jan 25, 2024

Ottima PR grazie. Riesci a caricare un test apposito? Ci sono già alcuni test simili.

Si! Ora gli dò uno sguardo

@robyf70 robyf70 force-pushed the 14.0-l10n_it_intrastat_statement-fix_compensation_not_in_period branch 2 times, most recently from 3d1d483 to c45077f Compare January 25, 2024 11:27
@robyf70
Copy link
Contributor Author

robyf70 commented Jan 25, 2024

@sergiocorato Fatto!

sergiocorato
sergiocorato requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semplificherei la funzione che controlla la data.
Inoltre questo controllo (ma anche quelli nei test attuali) che la p.iva del partner sia presente nel file non sembra utile, visto che lo stesso partner potrebbe essere sia nella sezione acquisti che in quelle rettifiche.
È invece utile l'ultimo check della lunghezza delle linee per capire se c'è la nota di credito, ma non mi sembra male esplicitare i controlli (anche perchè non viene controllato l'importo delle righe).

l10n_it_intrastat_statement/models/intrastat_statement.py Outdated Show resolved Hide resolved
l10n_it_intrastat_statement/tests/test_intrastat_statement.py Outdated Show resolved Hide resolved
@robyf70 robyf70 force-pushed the 14.0-l10n_it_intrastat_statement-fix_compensation_not_in_period branch from c45077f to 70becc8 Compare January 25, 2024 16:47
sergiocorato
sergiocorato approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie!

@sergiocorato
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3889-by-sergiocorato-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8e84b0c into OCA:14.0 Jan 26, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7179b24. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiocorato sergiocorato sergiocorato approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[14/16][l10n_it_intrastat_statement] Bug sulla compensazione delle note di credito emesse/ricevute
3 participants
@robyf70 @sergiocorato @OCA-git-bot