Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] FIX l10n_it_reverse_charge avoiding extra "exchange difference" entry #3879

Closed
wants to merge 1 commit into from
Closed

[16.0] FIX l10n_it_reverse_charge avoiding extra "exchange difference" entry #3879

wants to merge 1 commit into from

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Jan 22, 2024

Estensione di #3864

Altrimenti la registrazione che chiude le autofatture sarebbe di questo tipo:

image

quindi con una valuta estera ma senza importo.

Questo produce (mentre su v12 no) una registrazione extra di questo tipo:

image

@eLBati eLBati mentioned this pull request Jan 22, 2024
Open
3 tasks
@francesco-ooops francesco-ooops linked an issue Jan 23, 2024 that may be closed by this pull request
Autofatture in valuta con differenza cambio evidenziato che non le chiude totalmente #3863
Open
3 tasks
@eLBati
Copy link
Member Author

eLBati commented Feb 6, 2024

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

SirAionTech
SirAionTech requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Puoi aggiungere un test? Così si evitano regressioni

l10n_it_reverse_charge/models/account_move.py
@@ -221,7 +226,9 @@ def rc_payment_credit_line_vals(self, line_to_reconcile):
)
account = line_to_reconcile.account_id

line_values = self._rc_line_values(account, credit, debit)
line_values = self._rc_line_values(
account, credit, debit, line_to_reconcile.amount_currency
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qui e sotto, penso sia meglio

Suggested change
account, credit, debit, line_to_reconcile.amount_currency
account, credit, debit, line_amount_currency=line_to_reconcile.amount_currency

Così se vengono aggiunti altri args o kwargs prima di questo non si rischia di assegnare il valore al parametro sbagliato, cosa ne pensi?

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 16, 2024
@eLBati eLBati mentioned this pull request Jun 28, 2024
Merged
@odooNextev odooNextev mentioned this pull request Jun 28, 2024
Open
2 tasks
@MaurizioPellegrinet
Copy link

Appena disponibile runboat la provo

odooNextev
odooNextev reviewed Jun 28, 2024
View reviewed changes
l10n_it_reverse_charge/models/account_move.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eLBati la differenza (secondo me) sostanziale tra la mia e la tua PR è nel metodo compute_rc_amount_tax_main_currency perchè mi tengo da parte il valore della fattura originale per evitare una conversione di un valore già convertito e quindi possibili errori di arrotondamenti:
https://github.com/OCA/l10n-italy/pull/4238/files#diff-3c6a29bf7c09821dd6605e9b9c729ab09d0c83b13505138134c227b0b202ac2dR184

Per il resto sono molto simili e posso pensare di aggiungere un test

@eLBati
Copy link
Member Author

eLBati commented Jul 19, 2024

#4238 (comment)

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024
@SirAionTech SirAionTech added the needs fixing Has conflicts or is failing mandatory CI checks label Aug 21, 2024
@eLBati
Copy link
Member Author

eLBati commented Oct 24, 2024 •
edited
Loading

Avendo fatto merge di #4238 , questa si può chiudere giusto @odooNextev ?

@francesco-ooops
Copy link
Contributor

francesco-ooops commented Oct 24, 2024 •
edited
Loading

@eLBati dunque confermi che #4238 risolve il problema indicato in #3863 ?

@eLBati
Copy link
Member Author

eLBati commented Oct 25, 2024

@eLBati dunque confermi che #4238 risolve il problema indicato in #3863 ?

sì

@francesco-ooops
Copy link
Contributor

@eLBati allora direi che chiudo dato che questa risolve #3863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odooNextev odooNextev odooNextev left review comments

@SirAionTech SirAionTech SirAionTech requested changes

Assignees
No one assigned
Labels
16.0 needs fixing Has conflicts or is failing mandatory CI checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autofatture in valuta con differenza cambio evidenziato che non le chiude totalmente
6 participants
@eLBati @OCA-git-bot @MaurizioPellegrinet @francesco-ooops @odooNextev @SirAionTech