Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [IMP] l10n_it_delivery_note: link carrier with delivery method #3838

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[14.0] [IMP] l10n_it_delivery_note: link carrier with delivery method #3838

merged 1 commit into from
Feb 1, 2024

Conversation

renda-dev
Copy link
Contributor

@renda-dev renda-dev commented Jan 11, 2024 •
edited
Loading

  • Aggiunta relazione tra metodo di spedizione (delivery.carrier) e vettore (res.partner)
  • Aggiunto script di migrazione per relazionare i vettori con i metodi di spedizione già esistenti nei DdT
  • Aggiunto messaggio di avvertimento per futura estendibilità nel stock.delivery.note.base.wizard
  • Utilizzo del messaggio di avvertimento per controllare che i metodi di spedizione coincidano tra diversi picking sia alla selezione che alla validazione del DdT

Alternativa a #3815

@OCA-git-bot
Copy link
Contributor

Hi @aleuffre, @MarcoCalcagni,
some modules you are maintaining are being modified, check this out!

@renda-dev renda-dev force-pushed the 14.0-imp-l10n_it_delivery_note-carrier branch from 11f04c1 to 19693e7 Compare January 11, 2024 16:23
@andreampiovesana andreampiovesana mentioned this pull request Jan 12, 2024
Closed
andreampiovesana
andreampiovesana suggested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non userei il carrier_id come related ma lo compilerei come computed

@renda-dev renda-dev force-pushed the 14.0-imp-l10n_it_delivery_note-carrier branch 3 times, most recently from 351b95e to 4ad93b6 Compare January 12, 2024 09:17
@renda-dev
Copy link
Contributor Author

non userei il carrier_id come related ma lo compilerei come computed

Sistemato, grazie!

andreampiovesana
andreampiovesana reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

carrier_ids a cosa serve? io lo escluderei da questa pr

@renda-dev renda-dev force-pushed the 14.0-imp-l10n_it_delivery_note-carrier branch 5 times, most recently from 13c08c3 to 8cfa1a1 Compare January 15, 2024 16:55
@francesco-ooops francesco-ooops mentioned this pull request Jan 15, 2024
Closed
2 tasks
@francesco-ooops francesco-ooops linked an issue Jan 15, 2024 that may be closed by this pull request
[l10n_it_delivery_note] - usare lo stesso carrier nel DN e nel picking #3816
Closed
2 tasks
@renda-dev renda-dev force-pushed the 14.0-imp-l10n_it_delivery_note-carrier branch from 8cfa1a1 to 81c14e6 Compare January 16, 2024 13:51
@renda-dev renda-dev force-pushed the 14.0-imp-l10n_it_delivery_note-carrier branch 9 times, most recently from 7bf1c8e to a37158b Compare January 22, 2024 16:21
francesco-ooops
francesco-ooops approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funzionale ok!

  • Aggiunta la dipendenza a delivery_carrier_partner per distinguere metodo di consegna da vettore (n metodi di consegna relazionati a 1 vettore)
  • Aggiunto vettore al report (opzionale, tramite setting)
  • Non è stato modificato il dominio dei picking che possono essere aggiunti ad un DN;
  • Sono stati implementati dei warning non bloccanti alla validazione DN per far verificare all'utente la correttezza delle seguenti casistiche:
  • vettore impostato nel DN != da quello dei picking correlati;
  • picking correlati hanno metodi di consegna relazionati a diversi vettori;
  • picking corretlati hanno diversi metodi di consegna per lo stesso vettore.

@renda-dev renda-dev force-pushed the 14.0-imp-l10n_it_delivery_note-carrier branch 5 times, most recently from b15892c to 42f92c2 Compare January 30, 2024 13:07
francesco-ooops
francesco-ooops approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, abbiamo aggiunto anche nel report "Carrier" e "Delivery method" (opzionali, da settings) mantenendo invariato il flusso corrente.

Attendo review poi procediamo al merge

aleuffre
aleuffre approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

andreampiovesana
andreampiovesana approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@MarcoCalcagni @tafaRU possiamo mergiare?

@renda-dev
Copy link
Contributor Author

toglierei string=

Sarei più per lasciarlo, quel valore del picking viene poi utilizzato per impostare automaticamente il "Delivery Method" all'interno del DdT.

Siccome ci sono vari warning relativi a "Delivery Method" diversi tra di loro, aiuta a comprendere più facilmente come risolvere tali problemi.

@andreampiovesana

@aleuffre aleuffre force-pushed the 14.0-imp-l10n_it_delivery_note-carrier branch from 42f92c2 to 4a71c0d Compare February 1, 2024 09:33
@aleuffre
Copy link
Contributor

aleuffre commented Feb 1, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3838-by-aleuffre-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit abf6442 into OCA:14.0 Feb 1, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4ea2b6d. Thanks a lot for contributing to OCA. ❤️

@aleuffre aleuffre deleted the 14.0-imp-l10n_it_delivery_note-carrier branch February 1, 2024 13:42
@sergiocorato sergiocorato mentioned this pull request Feb 15, 2024
Merged
@PicchiSeba PicchiSeba restored the 14.0-imp-l10n_it_delivery_note-carrier branch March 1, 2024 09:51
@PicchiSeba PicchiSeba deleted the 14.0-imp-l10n_it_delivery_note-carrier branch March 1, 2024 11:36
@PicchiSeba PicchiSeba mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@andreampiovesana andreampiovesana andreampiovesana approved these changes

@GSLabIt GSLabIt GSLabIt approved these changes

Assignees
No one assigned
Labels
14.0 approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[l10n_it_delivery_note] - usare lo stesso carrier nel DN e nel picking
6 participants
@renda-dev @OCA-git-bot @francesco-ooops @aleuffre @GSLabIt @andreampiovesana