Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [FIX] l10n_it_fatturapa_out: fix migration script #3696

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[16.0] [FIX] l10n_it_fatturapa_out: fix migration script #3696

merged 1 commit into from
Feb 2, 2024

Conversation

odooNextev
Copy link
Contributor

E' necessario modificare lo script per migrare correttamente il modulo dalla v14 alla v16.

Infatti senza rimuovere preventivamente l'ereditarietà dalla vista view_fatturapa_in_attachment_form, questa verrebbe considerata come un'estensione anche nella v16 ed andrebbe in errore.

Inoltre bisogna considerare il caso in cui non ci siano costanti da eliminare altrimenti si verificherebbe un errore bloccante.

@odooNextev odooNextev changed the title [16.0] [FIX] l10n_fatturapa_out: fix migration script [16.0] [FIX] l10n_it_fatturapa_out: fix migration script Nov 9, 2023
@odooNextev odooNextev mentioned this pull request Nov 9, 2023
Closed
4 tasks
@francesco-ooops francesco-ooops linked an issue Dec 19, 2023 that may be closed by this pull request
[16.0] Errori nella migrazione dei moduli del repo #3711
Closed
4 tasks
mde-scopea
mde-scopea approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mde-scopea mde-scopea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@stenext stenext force-pushed the 16.0-fix-l10n_it_fatturapa_out branch from bffabaf to 0f0069d Compare February 1, 2024 13:25
@francesco-ooops
Copy link
Contributor

@scigghia @TheMule71 @eLBati dato che sembra essere lo stesso fix di #3915, potete verificare se risolve?

SirAionTech
SirAionTech requested changes Feb 1, 2024
View reviewed changes
l10n_it_fatturapa_out/migrations/16.0.1.0.0/pre-migrate.py Outdated
Comment on lines 33 to 34
view = env.ref("l10n_it_fatturapa_out.view_fatturapa_out_attachment_form")
view.inherit_id = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questo si può rimuovere? Per i motivi di cui parlammo due settimane fa in #3694 (review)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non mi ricordavo più...

@stenext stenext force-pushed the 16.0-fix-l10n_it_fatturapa_out branch from 0f0069d to cd1ddee Compare February 1, 2024 16:12
SirAionTech
SirAionTech approved these changes Feb 2, 2024
View reviewed changes
l10n_it_fatturapa_out/migrations/16.0.1.0.0/pre-migrate.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come mai cambia la versione della migrazione?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perchè serve appena si installa il modulo e non alla versione corrente
ne avevamo parlato qualche venerdì fa

@eLBati
Copy link
Member

eLBati commented Feb 2, 2024

/ocabot merge patch

@eLBati eLBati mentioned this pull request Feb 2, 2024
Closed
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3696-by-eLBati-bump-patch, awaiting test results.

@francesco-ooops francesco-ooops mentioned this pull request Feb 2, 2024
Closed
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit d589f8d into OCA:16.0 Feb 2, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dd014a0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirAionTech SirAionTech SirAionTech approved these changes

@mde-scopea mde-scopea mde-scopea approved these changes

Assignees
No one assigned
Labels
16.0 approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[16.0] Errori nella migrazione dei moduli del repo
6 participants
@odooNextev @francesco-ooops @eLBati @OCA-git-bot @mde-scopea @SirAionTech